Opened 3 years ago

Closed 3 years ago

#5051 closed enhancement (complete)

check gtest compatibility with the used C++ (>=11) compiler

Reported by: fdupont Owned by: fdupont
Priority: low Milestone: Kea1.2
Component: Unclassified Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

Some Google Test distribs have a bug with C++>=11 compiler. This ticket adds an explicit test during configure phase.

Subtickets

Change History (4)

comment:1 Changed 3 years ago by fdupont

  • Owner set to stephen
  • Status changed from new to reviewing

This is part of #4631 framework. Please review (BTW it was included on the (rebased now) trac4631). The ChangeLog entry will be for #4631 itself.

comment:2 Changed 3 years ago by hschempf

  • Milestone changed from Kea-proposed to Kea1.2

Accept 1.2 Low, per Kea team meeting 10/20/2016

comment:3 Changed 3 years ago by stephen

  • Owner changed from stephen to fdupont

Review commit c37654b677fab42a4fe205e9043934f2d11e3a1a

Looks OK and the changes work. However, I suggest changing the error message from:

XXX_TRUE() Gtest macros won't compile: please use a different version of Gtest, e.g., git one

to

Google Test macros won't compile; the most likely reason is that a later version of Google Test is required

I don't need to see this again, please merge when the message has been updated.

comment:4 Changed 3 years ago by fdupont

  • Resolution set to complete
  • Status changed from reviewing to closed

Merged. Closing.

Note: See TracTickets for help on using tickets.