Opened 4 years ago

Closed 3 years ago

#5027 closed task (complete)

Implement repository structure for premium components

Reported by: stephen Owned by: tomek
Priority: high Milestone: Kea1.2
Component: build system Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 16 Internal?: no

Description

Ticket #5026 defines how the repository will be laid out to accommodate premium components. This ticket is for the implementation of that structure.

Subtickets

Change History (12)

comment:1 Changed 3 years ago by tomek

  • Milestone changed from Kea-proposed to Kea1.2

comment:2 Changed 3 years ago by tomek

  • Priority changed from medium to high

comment:3 Changed 3 years ago by tomek

  • Owner set to tomek
  • Status changed from new to assigned

comment:4 Changed 3 years ago by tomek

  • Owner changed from tomek to Unassigned
  • Status changed from assigned to reviewing

This ticket is ready for review. Please note that the review scope is radically different compared to a usual ticket. Make sure you:

  • build the code as usual
  • build the code with premium checked out
  • be aware that there is some outstanding work to be done. This ticket was about organizing the repo and not fixing any issues in the legal logging hook. In particular, it seem the library is not installed, so makefiles have to be modified. Also, the COPYING file is currently empty and all the source files have incorrect license information.

comment:5 Changed 3 years ago by marcin

  • Owner changed from Unassigned to marcin

comment:6 Changed 3 years ago by marcin

  • Owner changed from marcin to tomek

configure.ac
The output when searching for the premium package is not consistent with output for other checks:

checking whether optreset variable is defined in unistd.h... yes
checking if premium package is available... not found

It should be "no" rather than "not found".

Same here:

Package:
  Name:            kea
  Version:         1.1.0-git
  Extended version:1.1.0-git (git 28431a0b45f27e64d16d1abe40f9bf3b34b2ad0e)
  OS Family:       BSD
  Using GNU sed:   no
  Premium package: Not found

With the premium repository checked out, the configuration seems to go fine and the code begins to compile, however it fails on building the submodule because it can't see boost. But, I am aware that you said that this ticket is not about fixing it. However, it would be good to make sure we have a ticket for fixing it.

Other than that, we have some email thread open, so I responded in this thread with some further questions.

comment:7 Changed 3 years ago by marcin

With all the clarifications you have made over the email I don't have any further comments beyond the two above.

comment:8 Changed 3 years ago by tomek

  • Add Hours to Ticket changed from 0 to 1
  • Owner changed from tomek to marcin
  • Total Hours changed from 0 to 1

Thanks for testing this. I have updated the configure.ac and tested that it builds properly on FreeBSD 11. The code also prints "no" instead of "not found".

Can you verify that it solves your problem? As I understand it, you have to do the pull in premium/ directory. The "pull" issued in top level tree will not propagate to derived projects.

Hopefully this addresses all your comments.

comment:9 Changed 3 years ago by tomek

  • Add Hours to Ticket changed from 1 to 0
  • Resolution set to complete
  • Status changed from reviewing to closed
  • Total Hours changed from 1 to 16

As discussed on jabber, this code is ready for merge.

Merged to master, closing ticket.

comment:10 Changed 3 years ago by tomek

  • Resolution complete deleted
  • Status changed from closed to reopened

comment:11 Changed 3 years ago by tomek

  • Owner changed from marcin to tomek
  • Status changed from reopened to assigned

comment:12 Changed 3 years ago by tomek

  • Resolution set to complete
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.