Opened 3 years ago

Closed 3 years ago

Last modified 2 years ago

#5010 closed defect (fixed)

--with-cql does not detect Cassandra, yet the build continues

Reported by: tomek Owned by: fdupont
Priority: low Milestone: Kea1.3 beta
Component: build system Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 1
Total Hours: 0 Internal?: no

Description

I have used the following parameters for configure:

./configure --with-dhcp-mysql --with-pgsql --with-cql

The script detected MySQL and PgSQL, but failed to detect Cassandra. That is sort of ok, assuming Cassandra is located in some non-standard location. What is not fine is that the configure script simply disabled Cassandra and continued compilation. It should have reported an error and abort.

Subtickets

Change History (13)

comment:1 Changed 3 years ago by stephen

  • Milestone changed from Kea-proposed to Kea1.2
  • Priority changed from medium to low

comment:2 Changed 3 years ago by fdupont

  • Owner set to fdupont
  • Status changed from new to accepted

comment:3 Changed 3 years ago by fdupont

  • Add Hours to Ticket changed from 0 to 1
  • Status changed from accepted to reviewing

Done but I'd like to look at GitHub Cassandra Pos in case I can find is something better there.

comment:4 Changed 3 years ago by fdupont

  • Owner changed from fdupont to UnAssigned

Found nothing about Cassandra in configure.ac. Ready for review.

comment:5 Changed 3 years ago by tomek

  • Milestone changed from Kea1.2 to Kea1.2-final

Code freeze for 1.2-beta. Moving all remaining open tickets to 1.2-final.

comment:6 Changed 3 years ago by tomek

  • Milestone changed from Kea1.2-final to Kea1.3

As discussed on 2017-04-13 Kea call, moving all low review tickets that have not started review yet to Kea1.3.

comment:7 Changed 3 years ago by stephen

  • Owner changed from UnAssigned to stephen

comment:8 Changed 3 years ago by stephen

  • Owner changed from stephen to fdupont

Reviewed commit 325d49a7c693dfbd9b7f5ae340a34c56ced49d08

Although it is a trivial fix and orks in most cases, unfortunately too many instances of the "cql_config" variable were upper-cased. The original code is below - only the line marked "<---" requires the variable to be upper-cased.

cql_config="no"
AC_ARG_WITH([cql],
  AC_HELP_STRING([--with-cql=PATH],
    [path to the Cassandra CQL 'cql_config' script]),
    [cql_config="$withval"])

if test "${cql_config}" = "yes" ; then
    cql_config="/usr/bin/cql_config"  <--- This should read CQL_CONFIG="/usr/bin/cql_config"
elif test "${cql_config}" != "no" ; then
    CQL_CONFIG="${withval}"           (This works, but should more logically read CQL_CONFIG="$cql_config")
fi

If all instances of the cql_config variable are upper-cased, the presence of a directory or executable file named "no" in the top-level Kea directory causes "configure" to fail.

This minor change does not need a ChangeLog entry.

comment:9 Changed 3 years ago by fdupont

  • Owner changed from fdupont to nobody

Applied proposed change. Ready for final review.

comment:10 Changed 3 years ago by fdupont

  • Owner changed from nobody to UnAssigned

comment:11 Changed 3 years ago by stephen

  • Owner changed from UnAssigned to fdupont

Review commit 212b35a090ea646f159f9e5c61b725f324f9ddc2

All OK, please merge.

comment:12 Changed 3 years ago by fdupont

  • Resolution set to fixed
  • Status changed from reviewing to closed

Merged. Closing.

comment:13 Changed 2 years ago by vicky

  • Milestone changed from Kea1.3 to Kea1.3 beta

Milestone renamed

Note: See TracTickets for help on using tickets.