Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#480 closed defect (fixed)

clang++/FreeBSD doesn't compile BIND 10 with optimization

Reported by: jinmei Owned by: jinmei
Priority: low Milestone:
Component: build system Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity:
Sub-Project: Feature Depending on Ticket:
Estimated Difficulty: 0.0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

See #474. There seems to be something incompatible with clang++ in ccsession_unittests.cc.

Subtickets

Attachments (2)

ccsession_unittests.cc.diff (2.5 KB) - added by jinmei 9 years ago.
ccsession_unittests.cc.correct.diff (2.2 KB) - added by jinmei 9 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 9 years ago by jinmei

I found a heuristic workaround. If I divided CCSessionTest::checkCommand into two sub testcases (covering the same set of tests) it compiled and tests passed. Maybe the resulting macro/template expansion is too big for clang++.

This is an ad hoc hack, but this is the only case (at least so far) we have this problem, so I propose adopting this workaround and moving forward for now.

I'm attaching a proposed diff (no branch at the moment).

I'm giving this ticket Jelte, because all reviewers should check for the change is to confirm it doesn't change the tests in semantics.

I'm not intending to add a changelog entry for this change.

Changed 9 years ago by jinmei

comment:2 Changed 9 years ago by jinmei

  • Owner changed from jreed to jelte
  • Status changed from new to reviewing

Changed 9 years ago by jinmei

comment:3 Changed 9 years ago by jinmei

The first diff was not a diff file. Apparently I made some operational error.

The new one (...correct.diff) is the intended patch.

comment:4 Changed 9 years ago by jinmei

Since the code base has become stale since created, I've created a branch, merging the patch and resolving conflicts with the latest master. Branch name is "trac480".

comment:5 follow-up: Changed 9 years ago by jelte

  • Owner changed from jelte to jinmei

Note: Haven't tried to compile it with clang, so i'll trust you did :)

Test code changes look good, these changes don't change test behaviour, so go ahead and merge.

comment:6 in reply to: ↑ 5 Changed 9 years ago by jinmei

Replying to jelte:

Note: Haven't tried to compile it with clang, so i'll trust you did :)

Test code changes look good, these changes don't change test behaviour, so go ahead and merge.

Thanks, merged to master (with some unexpected mess and fix:-).

Closing ticket.

comment:7 Changed 9 years ago by jinmei

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:8 Changed 9 years ago by stephen

  • Milestone feature backlog item deleted

Milestone feature backlog item deleted

Note: See TracTickets for help on using tickets.