Opened 9 years ago

Closed 9 years ago

#478 closed defect (fixed)

add_remote_config() cannot import custom config

Reported by: jinmei Owned by: jinmei
Priority: medium Milestone:
Component: Unclassified Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity:
Sub-Project: Feature Depending on Ticket:
Estimated Difficulty: 0.0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

I noticed this bug when I tried the "proposed change for configuring sqlite3 DB in the "from build" mode" I sent to bind10-dev earlier this week. That is, zonemgr and xfrout cannot get the manually configured "database_file" in b10-config.db.

I figured out how this happened, and will submit a proposed fix.

Subtickets

Change History (10)

comment:1 Changed 9 years ago by jinmei

The trac478 branch is my proposed fix. It's ready for review.

Proposed changelog entry:

  144.?	[bug]		jinmei
	python/isc/config: Fixed a bug that importing custom configuration
	(in b10-config.db) of a remote module didn't work.
	(Trac #478, git XXX)

I'm tentatively assigning it to Jelte, who I believe is the most familiar with this stuff.

comment:2 Changed 9 years ago by jinmei

  • Owner changed from jinmei to jelte
  • Status changed from new to reviewing

comment:3 follow-up: Changed 9 years ago by jelte

  • Owner changed from jelte to jinmei

Ack, good call.

Note: you seem to have branched this from trac473, not master. So I think we shouldn't merge this until I have addressed your review comments in that branch :) (or we could cherrypick the commit, but I don't think there's too much harm in waiting for a bit).

comment:4 in reply to: ↑ 3 Changed 9 years ago by jinmei

Replying to jelte:

Ack, good call.

Note: you seem to have branched this from trac473, not master.

Oh really? Poor novice git operator:-)

So I think we shouldn't merge this until I have addressed your review comments in that branch :) (or we could cherrypick the commit, but I don't think there's too much harm in waiting for a bit).

Okay. Do you think #473 will be completed soon (before the f2f meeting)? It's not super critical, but it would be convenient if I could work on the "from build" change with this fix soon.

comment:5 Changed 9 years ago by jinmei

  • Owner changed from jinmei to jelte

comment:6 follow-up: Changed 9 years ago by jelte

Yes, almost done with your comments.

comment:7 in reply to: ↑ 6 Changed 9 years ago by jinmei

Replying to jelte:

Yes, almost done with your comments.

I've recognized #473 has been merged and closed. Is it now okay for this patch to merge?

comment:8 follow-up: Changed 9 years ago by jelte

  • Owner changed from jelte to jinmei

Oh yeah, sorry, please go ahead. Let's see how well git handles this :)

comment:9 in reply to: ↑ 8 Changed 9 years ago by jinmei

Replying to jelte:

Oh yeah, sorry, please go ahead. Let's see how well git handles this :)

Okay, thanks. Merged, closing ticket.

comment:10 Changed 9 years ago by jinmei

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.