Opened 9 years ago

Closed 9 years ago

#476 closed enhancement (complete)

Refine Query::getAdditional

Reported by: zzchen_pku Owned by: vorner
Priority: medium Milestone:
Component: Unclassified Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity:
Sub-Project: Feature Depending on Ticket:
Estimated Difficulty: 0.0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

There are some duplicate code lines due to subsequent merge, we need to refine it.

Subtickets

Change History (2)

comment:1 follow-up: Changed 9 years ago by zzchen_pku

  • Owner changed from zzchen_pku to vorner
  • Status changed from new to reviewing

Since it's quite trivial, just remove some duplicate code lines, I modified it directly in master : 0e1d792f2eb4eaee37a371dc299fa9ff9826bee3 (may be I should create a branch for review next time), please take a look at this, thanks.

comment:2 in reply to: ↑ 1 Changed 9 years ago by vorner

  • Resolution set to complete
  • Status changed from reviewing to closed

Replying to zzchen_pku:

Since it's quite trivial, just remove some duplicate code lines, I modified it directly in master : 0e1d792f2eb4eaee37a371dc299fa9ff9826bee3 (may be I should create a branch for review next time), please take a look at this, thanks.

Yes, you are right with the branch. But this change is OK, so I'm closing it for you.

Note: See TracTickets for help on using tickets.