Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#471 closed defect (fixed)

b10-config.db missing resolver settings causes it to not listen

Reported by: jreed Owned by: jelte
Priority: medium Milestone: R-Team-Sprint-20110316
Component: Unclassified Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity:
Sub-Project: Feature Depending on Ticket:
Estimated Difficulty: 3.0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

My b10-config.db existed but didn't contain the configurations for the resolver. The resolver started but never did the "New config comes:" and so never listened as a TCP or UDP server nor set the forward addresses.

I think the defaults (from spec or later, a command line) should be used if not defined in the b10-config.db.

Subtickets

Change History (9)

comment:1 Changed 9 years ago by jreed

  • Resolution set to duplicate
  • Status changed from new to closed

This was later duplicated by #518. Closing this one.

comment:2 Changed 9 years ago by jelte

  • Milestone set to R-Team-Sprint-20110316
  • Resolution duplicate deleted
  • Status changed from closed to reopened

Actually, since #518 is more involved, and getting the resolver to simply listen on a hardcoded value if nothing is configured is quite easy, i'm reopening this ticket as a temoporary solution until we get to #518.

comment:3 Changed 9 years ago by jelte

  • Owner set to UnAssigned
  • Status changed from reopened to reviewing

comment:4 Changed 9 years ago by stephen

  • Owner changed from UnAssigned to stephen

comment:5 Changed 9 years ago by stephen

  • Owner changed from stephen to jelte

src/bin/resolver/resolver.cc
OK, although setConfigured() is really quite trivial and couple be put inline in the header.

src/bin/resolver/resolver.h
Some typos in the first line of the header comments of setConfigured()

src/lib/config/module_spec.cc
validateSpecList(): the code could be simplified: If the test on version succeeds, the "if (!found)" branch will never be taken: so it could be placed inside the "else" clause. In fact, by inverting the test, there is no need for an "else" branch.

There should be a test to ensure that version is not considered a configuration item.

comment:6 Changed 9 years ago by jelte

  • Owner changed from jelte to stephen

61e7f493f8f44c7ccb8f2d9ef0186dd15e499097 should address all 4 issues, please check

comment:7 Changed 9 years ago by stephen

  • Owner changed from stephen to jelte

All OK, please merge.

comment:8 Changed 9 years ago by jelte

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:9 Changed 9 years ago by jelte

  • Estimated Difficulty changed from 0.0 to 3
Note: See TracTickets for help on using tickets.