Opened 3 years ago

Last modified 3 years ago

#4537 new enhancement

Pass copy of a subnet to callouts within hook library

Reported by: marcin Owned by:
Priority: medium Milestone: Outstanding Tasks
Component: dhcp Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 40 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

The #4497 resolves the problem with accidental modifications of configured options by hook libraries by implementing copy on reference options from the packet. The similar issue is going to arise with subnets. Currently we pass the pointer to the subnet to the subnet4_select and subnet6_select callout. Modification of subnet parameters will affect the configured subnet instance. Hence, we should probably copy subnet objects passed to the callouts. Such copying could take place only when the subnetX_select callout is installed.

Deep copying a subnet may be problematic as we have variant for DHCPv4, DHCPv6 and they come with various members, of which some contain collections of objects which should also be copyable.

Subtickets

Change History (1)

comment:1 Changed 3 years ago by hschempf

  • Milestone changed from Kea-proposed to Outstanding Tasks

Per July 7 meeting, move to outstanding

Note: See TracTickets for help on using tickets.