Opened 4 years ago

Closed 4 years ago

#4533 closed defect (fixed)

Release code should not have -Werror enable

Reported by: tomek Owned by: stephen
Priority: medium Milestone: Kea1.1
Component: build system Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

Dan reported issues with Kea compilation. The problem is that somewhere in boost headers there are unused parameters. We try to compile Kea with -Werror, so warnings like these are promoted to error. As a result, a user is not able to compile our software.

We use -Werror to pick errors in our code. It's ok to have it in development code, but it must not affect users. Therefore this flag has to be disabled for release versions of Kea.

Subtickets

Change History (7)

comment:1 Changed 4 years ago by fdupont

I strongly object to this and NetBSD package maintainers too. Note that on NetBSD the whole system (which includes all tools, libraries and commands) is compiled with -Werror. So it is not something so hard...
Note if you'd like to disable unused parameters you can do it in Makefile's where buggy boost headers are used or if you believe it is not enough at a global scale.

comment:2 Changed 4 years ago by hschempf

  • Milestone changed from Kea-proposed to Kea1.1

Per July 7 meeting, accept 1.1. 1hr estimate.

comment:3 Changed 4 years ago by stephen

  • Owner set to stephen
  • Status changed from new to accepted

comment:4 Changed 4 years ago by stephen

  • Owner changed from stephen to Unassigned
  • Status changed from accepted to reviewing

Ready for review. Suggested ChangeLog entry is

-Werror is no longer the default for compilation.  Promotion of all
compilation warnings to errors now requires the --with-error switch
to be specified when running configure.

Responding to Francis's comment, ideally we would specify -Werror in all builds. However, in order to do that we would need to disable specific warnings for specific versions of the Boost libraries and remember to re-enable them when the condition is fixed. Currently doing that is a lower priority than everything else we are doing

Last edited 4 years ago by stephen (previous) (diff)

comment:5 Changed 4 years ago by sar

  • Owner changed from Unassigned to sar

comment:6 Changed 4 years ago by sar

  • Owner changed from sar to stephen

There were some typos in the the comments. I have attempted to fix them, please do a pull and verify my changes.

Other than that it looks fine

comment:7 Changed 4 years ago by stephen

  • Resolution set to fixed
  • Status changed from reviewing to closed

Merged in commit 874e3a3f5cb10313856284646fcee7cf86e4fcce

Note: See TracTickets for help on using tickets.