Opened 4 years ago

Closed 4 years ago

#4531 closed defect (fixed)

Replace test by expr for < in

Reported by: fdupont Owned by: fdupont
Priority: low Milestone: Kea1.1
Component: Unclassified Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: Low
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no


Change History (6)

comment:1 Changed 4 years ago by fdupont

  • Defect Severity changed from N/A to Low
  • Owner set to fdupont
  • Status changed from new to accepted

comment:2 Changed 4 years ago by fdupont

  • Owner changed from fdupont to UnAssigned
  • Status changed from accepted to reviewing

Did a branch to help testing. Ready for review. BTW the hard point is what to put in an eventual ChangeLog entry (I leave this to the reviewer). And BTW test is known for its lack of consistency and the Open Group doc (which replaced Posix) warns explicitly against "historical" < and co commands. And test a -lt b works on integers, so the proposed solution is the right one IMHO.

comment:3 Changed 4 years ago by hschempf

  • Milestone changed from Kea-proposed to Kea1.1

Per June 30 team meeting, accept 1.1 under bug fixing. Already in review, estimated 1 hr to complete.

comment:4 Changed 4 years ago by marcin

  • Owner changed from UnAssigned to marcin

comment:5 Changed 4 years ago by marcin

  • Owner changed from marcin to fdupont

Your change looks good and appears to compile on my MAC, plus on multiple selected systems in Jenkins. So, I think it is ok to merge. The only thing left is if we want to credit the person who opened the pull request. We do put contributions into the AUTHORS file, and perhaps we should also put this contributor there? Maybe we should ask him if he wants to be credited?

comment:6 Changed 4 years ago by fdupont

  • Resolution set to fixed
  • Status changed from reviewing to closed

Merged. Closing.

Note: See TracTickets for help on using tickets.