Opened 4 years ago

Closed 4 years ago

#4510 closed defect (fixed)

Kea handles backslashes incorrectly in options

Reported by: tomek Owned by: tomek
Priority: medium Milestone: Kea1.1
Component: ~dhcpconf(obsolete) Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0.5 Internal?: no

Description

Deniz Ozturk reported:

With the config line:

 { "name" : "boot-file-name", "data" : "\\SMSBoot\\x64\\wdsnbp.com”}

Kea sends double backslashes in boot-file-name option. When I don’t escape the backslashes in the kea.conf it complains with “Bad escape” error.

Expected (generated with isc-dhcp) and incorrect (generated with kea) traffic captures attached.

Subtickets

Change History (6)

comment:1 Changed 4 years ago by tomek

  • Status changed from new to reviewing

I believe I have fixed this issue. The code is available on trac4510 branch.

Please review.

Proposed ChangeLog? entry:

1XXX.	[bug]		tomek
	Escaped characters (e.g. backslashes) are now represented properly
	in options.
	(Trac #4510, git tbd)

comment:2 Changed 4 years ago by hschempf

  • Milestone changed from Kea-proposed to Kea1.1

Per team meeting, accept 1.1 as bug fixing. Estimated time remaining = .5d

comment:3 Changed 4 years ago by tomek

The original reporter just confirmed that the fix is working for him.

comment:4 Changed 4 years ago by stephen

  • Owner set to stephen

comment:5 Changed 4 years ago by stephen

  • Owner changed from stephen to tomek
  • Total Hours changed from 0 to 0.5

Reviewed commits 5a188f631da92b648ffb667543348df9e82c3899 to 22f72b302e4f3e86f8c52ab6e108718abfdf4282.

Looks good (as does the proposed ChangeLog) - please merge.

comment:6 Changed 4 years ago by tomek

  • Resolution set to fixed
  • Status changed from reviewing to closed

Merged, closing ticket. Thanks for the review.

Note: See TracTickets for help on using tickets.