Opened 9 years ago

Closed 7 years ago

Last modified 7 years ago

#443 closed defect (fixed)

[kean] Private copy of asiolink.h should be removed.

Reported by: vorner Owned by: kean
Priority: medium Milestone: Sprint-20130917
Component: resolver Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DNS Feature Depending on Ticket:
Estimated Difficulty: 0.0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

While developing NSAS, a private copy of asiolink.h header was added into lib/nsas. It contains only the IOAddress (but has an equal() method added). The include should be replaced by <asiolink/ioaddress.h> and equal() merged there (including possible tests).

Subtickets

Change History (13)

comment:1 Changed 9 years ago by jreed

  • Component changed from recurser to resolver

comment:2 Changed 8 years ago by shane

  • Defect Severity set to N/A
  • Milestone set to Next-Sprint-Proposed
  • Sub-Project set to DNS

Seems this file is empty now, except for some system header includes.

comment:3 Changed 7 years ago by stephen

Seems this file is empty now, except for some system header includes.

Yes - the task for this ticket is now to remove nsas/asiolink.h completely. Any .cc files including it should be modified to #include the relevant system headers (if required) directly.

comment:4 Changed 7 years ago by muks

  • Milestone set to Sprint-20130903
  • Summary changed from Private copy of asiolink.h should be removed. to [kean] Private copy of asiolink.h should be removed.

comment:5 Changed 7 years ago by kean

  • Owner set to kean
  • Status changed from new to assigned

comment:6 Changed 7 years ago by kean

  • Owner changed from kean to UnAssigned
  • Status changed from assigned to reviewing

comment:7 Changed 7 years ago by muks

  • Owner changed from UnAssigned to kean

Hi Kean

This branch looks mostly good, but was it necessary to add the <asiolink/asiolink.h> include when the original code seemed to compile fine without it?

comment:8 Changed 7 years ago by muks

Also, please run make distcheck and say if it has passed, as a file has been removed from the tree.

comment:9 Changed 7 years ago by kean

Muks, I have removed references to asiolink.h completely, and yes, make distcheck passes.

comment:10 Changed 7 years ago by kean

  • Owner changed from kean to muks

comment:11 Changed 7 years ago by muks

  • Owner changed from muks to kean

Hi Kean

This looks good now. Please go ahead and merge it. :)

See:
http://bind10.isc.org/wiki/GitWorkflow

under "Merging" section on how to merge it.

comment:12 Changed 7 years ago by kean

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:13 Changed 7 years ago by kean

No ChangeLog? entry needed - very trivial change that no users or developers are likely to care about.

Note: See TracTickets for help on using tickets.