Opened 4 years ago

Closed 3 years ago

#4328 closed defect (fixed)

Function make_pair compatibility

Reported by: zdohnal Owned by: marcin
Priority: medium Milestone: Kea1.1-final
Component: dhcp Version: git
Keywords: dhcp, C++11, C++14, C++99, pgsql_lease_mgr Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: Medium
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

Function make_pair has different syntax in C++11 standard and higher than it had in C++99. Please change return value of PgSqlLeaseMgr::getVersion() method in file pgsql_lease_mgr.cc to that way, which is compatible with old and newer standards.

Subtickets

Attachments (1)

diff (691 bytes) - added by fdupont 4 years ago.
git diff ...trac4328

Download all attachments as: .zip

Change History (12)

comment:1 Changed 4 years ago by zdohnal

  • Defect Severity changed from High to Medium
  • Priority changed from high to medium

comment:2 Changed 4 years ago by fdupont

  • Owner changed from jpopelka to fdupont
  • Status changed from new to accepted

I propose to remove the explicit types.

comment:3 Changed 4 years ago by fdupont

Done. Ready for review.

comment:4 Changed 4 years ago by fdupont

  • Owner changed from fdupont to UnAssigned
  • Status changed from accepted to reviewing

comment:5 Changed 4 years ago by zdohnal

May I ask, if there is any place, where I can download this patch from and test it? I am interested in your solution. I can not find it in your GitHub.

Changed 4 years ago by fdupont

git diff ...trac4328

comment:6 follow-up: Changed 4 years ago by tomek

Francis, keep in mind that the trac* branches are not available in github repo, unless you manually push them.

comment:7 Changed 4 years ago by hschempf

  • Milestone changed from Kea-proposed to Outstanding Tasks

per team meeting Mar 17, move to outstanding.

comment:8 in reply to: ↑ 6 Changed 4 years ago by fdupont

Replying to tomek:

Francis, keep in mind that the trac* branches are not available in github repo, unless you manually push them.

=> I know and this is why I attached the diff.

comment:9 Changed 3 years ago by tomek

  • Milestone changed from Outstanding Tasks to Kea1.2

comment:10 Changed 3 years ago by marcin

  • Milestone changed from Kea1.2 to Kea1.1-final
  • Owner changed from UnAssigned to marcin
  • Status changed from reviewing to accepted

Because this causes issues on gcc 6.0 and we want to compile on gcc 6.0 obviously, this should be fixed in Kea 1.1-final. Tomek agreed with this decision on jabber. Plus, we have pull requests #28 and #29 that implement this change.

comment:11 Changed 3 years ago by marcin

  • Resolution set to fixed
  • Status changed from accepted to closed

This fix is now merged to master.

Note: See TracTickets for help on using tickets.