Opened 4 years ago

Closed 4 years ago

#4326 closed defect (fixed)

Address minor coverity "must be fixed" items

Reported by: fdupont Owned by: fdupont
Priority: very low Milestone: Kea1.1
Component: Unclassified Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: .5 Internal?: no

Description


Subtickets

Change History (5)

comment:1 Changed 4 years ago by fdupont

  • Owner set to fdupont
  • Status changed from new to accepted

comment:2 Changed 4 years ago by fdupont

  • Owner changed from fdupont to UnAssigned
  • Status changed from accepted to reviewing

Done. Ready for review (note any interesting bugs have their own tickets).

comment:3 Changed 4 years ago by stephen

  • Owner changed from UnAssigned to stephen

comment:4 Changed 4 years ago by stephen

  • Owner changed from stephen to fdupont
  • Total Hours changed from 0 to .5

Reviewed commits efeb4479e934d145e44b9887a998259de8892017 to 3114642b99d5266c2b631be3f469284a785cbe5a

src/lib/util/threads/thread.cc
The indentation of the line initialising "tid_" in the Thread::Impl constructor appears to be incorrect.

src/lib/util/time_utilities.cc
I'm concerned about the use of the ULL suffix for a 64-bit literal. As far as I can see, that syntax was introduced in C++0x so may not be valid for older C++98 compilers. Could we change it to use "static_cast<uint64_t>" instead?

A ChangeLog entry about fixing Coverity-detected issues is needed.

comment:5 Changed 4 years ago by fdupont

  • Resolution set to fixed
  • Status changed from reviewing to closed

Done, merged.

Note: See TracTickets for help on using tickets.