Opened 4 years ago

Closed 4 years ago

#4318 closed defect (fixed)

Fix DUID based reservations in DHCPv4

Reported by: marcin Owned by: marcin
Priority: medium Milestone: Kea1.1
Component: host-reservations Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 4 Add Hours to Ticket: 0.5
Total Hours: 2.5 Internal?: no

Description

It is possible to specify a DUID as an identifier for host reservations. However, the value is misused by the server which compares the whole content of the client identifier option with a DUID. What it should do is to extract DUID from the client identifier option if the Type is 255 and compare with that. This ticket is to correct it.

Subtickets

Change History (8)

comment:1 Changed 4 years ago by marcin

  • Owner set to marcin
  • Status changed from new to accepted

comment:2 Changed 4 years ago by marcin

  • Owner changed from marcin to UnAssigned
  • Status changed from accepted to reviewing

The proper handling of DUID value on the server side had been implemented as part of one of the previous ticket. I used this particular ticket to only add unit tests that check that reservation by DUID is possible and the proper address is assigned. I also extended an existing unit test to verify that the server picks the right order of identifier types to find a reservation.

This is not a user visible change so I a ChangeLog entry doesn't seem to be required.

comment:3 Changed 4 years ago by marcin

  • Add Hours to Ticket changed from 0 to 2
  • Total Hours changed from 0 to 2

comment:4 Changed 4 years ago by marcin

  • Estimated Difficulty changed from 0 to 4

comment:5 Changed 4 years ago by tomek

  • Owner changed from UnAssigned to tomek

comment:6 Changed 4 years ago by tomek

  • Owner changed from tomek to marcin

dora_unittest.cc

Configurations 4 and 5 should be better documented. Saying that
"Conf. 4 uses different values in host-reservation-identifers" suggest
that 2 uses it too, which is incorrect.

Very good test. Thanks for writing it.

Code builds and unit-tests pass on Ubuntu 15.10 x64.

With the minor update mentioned before, the code will ready for merge.

comment:7 Changed 4 years ago by tomek

  • Add Hours to Ticket changed from 2 to 0.5
  • Total Hours changed from 2 to 2.5

comment:8 Changed 4 years ago by marcin

  • Resolution set to fixed
  • Status changed from reviewing to closed

Updated test configuration description and then merged with commit 36773ccfa58b450811d56beb6452bf6395bbb29e

Note: See TracTickets for help on using tickets.