Opened 4 years ago

Closed 4 years ago

#4307 closed defect (fixed)

uncaught exception in d2 server main()

Reported by: fdupont Owned by: fdupont
Priority: medium Milestone: Kea1.1
Component: Unclassified Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0.5 Internal?: no

Description

the D2Controller::instance() can raise an exception which is uncaught.
Reported by Coverity so inherits from #4262.

Subtickets

Change History (11)

comment:1 Changed 4 years ago by fdupont

  • Owner set to fdupont
  • Status changed from new to accepted

comment:2 Changed 4 years ago by fdupont

Similar bug more complex issue in perfdhcp (3 variants reported by Coverity).

comment:3 Changed 4 years ago by fdupont

Note Coverity warns (twice) about LOG_FATAL in dhcpv6 server but there is a not yet addressed comment about it?!

comment:4 Changed 4 years ago by fdupont

Similar (to perfdhcp) bug in message. And same comment (than dhcpv6) about LOG_FATAL in dhcpv4 server.

comment:5 Changed 4 years ago by fdupont

CID 1202722, 12027{18,19,20}, 1202702 for this ticket.
CID 12027{12.13}, 120270{0,1} for the known problem.

comment:6 Changed 4 years ago by fdupont

  • Owner changed from fdupont to UnAssigned
  • Status changed from accepted to reviewing

Done. Please review. Note the perfdhcp fix relies on the exceptions to be derived from std::exception something which is perhaps not the case with boost...

comment:7 Changed 4 years ago by hschempf

  • Milestone changed from Kea1.1 to Kea-proposed

This ticket needs to be reviewed by the team before it's added to 1.1, sending it to Kea-proposed.

comment:8 Changed 4 years ago by hschempf

  • Milestone changed from Kea-proposed to Kea1.1

Per team meeting 3/10, accept 1.1, estimate .5 days. This ticket fits within the effort of bug fixing

comment:9 Changed 4 years ago by stephen

  • Owner changed from UnAssigned to stephen

comment:10 Changed 4 years ago by stephen

  • Owner changed from stephen to fdupont
  • Total Hours changed from 0 to 0.5

Reviewed commit cac9c6712fa5a830605c16e33953b51106a0af0c to 04079bcd8060ab2fb455afc16ec13d86fbd1078d

All OK, please merge.

I think it needs a ChangeLog entry: something along the lines of "Fixed Coverity-detectede exception-handling issues" should be OK.

comment:11 Changed 4 years ago by fdupont

  • Resolution set to fixed
  • Status changed from reviewing to closed

Merged, closing. BTW IMHO there are still minor points to improve...

Note: See TracTickets for help on using tickets.