Opened 4 years ago

Closed 4 years ago

#4254 closed enhancement (complete)

perfdhcp: Add support for sending DHCPv4 renewals at the specified rate

Reported by: marcin Owned by: marcin
Priority: medium Milestone: Kea1.1
Component: perfdhcp Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

This ticket enables "-f" command line option for DHCPv4 server in perfdhcp. This commmand line option allows for specifying a rate at which perfdhcp sends renew requests to the DHCPv4 server.

Subtickets

Change History (10)

comment:1 Changed 4 years ago by marcin

  • Milestone changed from Kea-proposed to Kea1.1
  • Owner set to marcin
  • Status changed from new to accepted

comment:2 Changed 4 years ago by marcin

  • Owner changed from marcin to UnAssigned
  • Status changed from accepted to reviewing

This ticket is now ready for review. I enabled -f option for the DHCPv4 server tests, which works the same as for the DHCPv6.

Proposed ChangeLog entry:

10XX.	[func]		marcin
	perfdhcp now accepts -f option for DHCPv4 server testing, which
	enables lease renewals at the specified rate.
	(Trac #4254, git abcd)

comment:3 Changed 4 years ago by fdupont

  • Owner changed from UnAssigned to fdupont

comment:4 Changed 4 years ago by fdupont

  • Owner changed from fdupont to UnAssigned

I read the code, it seems OK but it has to be use with a real server.
I fixed spelling errors in the modified files, reindented a few comments and updated some copyrights. So please pull my changes.
About the next step, I don't know when I'll be able to perform a real test so I put back the ticket to review in the case someone has an opportunity.

comment:5 Changed 4 years ago by fdupont

  • Owner changed from UnAssigned to fdupont

comment:6 Changed 4 years ago by fdupont

  • Owner changed from fdupont to marcin

The inline help is incorrect: the -f<renew-rate> is in the DHCPv6 only options. BTW perhaps this ticket should be extended to -F<release-rate> too.
Still trying to understand how to use the -f option with DHCPv6...

comment:7 Changed 4 years ago by fdupont

Update:

  • -F/Release doesn't produce a reply for DHCPv4 so to extend -F to DHCPv4 is far to be trivial and can not be covered by this ticket.
  • on my Ubuntu 15.10 VM perfdhcp -f crashes for DHCPv6 and DHCPv4 at line 441 in stats_mgr.h in the ++ operator of boost:multi_index

comment:8 Changed 4 years ago by fdupont

Bug reproduced on Fedora 23. Create #4263 to fix it.

comment:9 Changed 4 years ago by fdupont

I merged the #4263 fix and now it works well. Note the documentation (manual and help) is still to be fixed (I can do it if you'd like: give me the ticket).

comment:10 Changed 4 years ago by marcin

  • Resolution set to complete
  • Status changed from reviewing to closed

Issues in documentation have been resolved and the code is now merged to master.

Note: See TracTickets for help on using tickets.