Opened 4 years ago

Closed 3 years ago

#4252 closed defect (fixed)

triage issues reported by coverity

Reported by: wlodekwencel Owned by: marcin
Priority: low Milestone: Kea1.1-final
Component: Unclassified Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 8
Total Hours: 8 Internal?: no

Description

triage issues reported by coverity, especially "uncaught exception"

Subtickets

Change History (13)

comment:1 follow-up: Changed 4 years ago by fdupont

  • Owner set to wlodekwencel
  • Status changed from new to assigned

Can you attach the report file?

comment:2 Changed 4 years ago by hschempf

  • Milestone changed from Kea-proposed to Kea1.1

Per team meeting Jan 27, accept 1.1. Estimate to be provided.

comment:3 in reply to: ↑ 1 Changed 4 years ago by wlodekwencel

  • Owner wlodekwencel deleted

Replying to fdupont:

Can you attach the report file?

No, report is available at kea project site on coverity.
https://scan.coverity.com/projects/kea?tab=overview

comment:4 Changed 4 years ago by fdupont

Created #4306, #4307, #4309 and #4310 to address some reports.

comment:5 Changed 4 years ago by tomek

  • Priority changed from medium to low

Decision on 2016-06-02 Kea call: Let's do this in 1.1 beta.

Last edited 4 years ago by tomek (previous) (diff)

comment:6 Changed 3 years ago by tomek

  • Milestone changed from Kea1.1 to Kea-1.1-final

comment:7 Changed 3 years ago by tomek

  • Milestone changed from Kea-1.1-final to Kea1.1-final

Milestone renamed

comment:8 Changed 3 years ago by marcin

Note: CID: 1372419, 1372420 and 1372421 are being addressed as part of the #5004. Therefore, this ticket should not address them.

comment:9 Changed 3 years ago by marcin

  • Owner set to marcin
  • Status changed from assigned to accepted

comment:10 Changed 3 years ago by marcin

  • Add Hours to Ticket changed from 0 to 8
  • Owner changed from marcin to UnAssigned
  • Status changed from accepted to reviewing
  • Total Hours changed from 0 to 8

I triaged all issues back to August 22nd, 2014. I changed the status of those that are absent as a result of the dedicated fix or moving the code around. I addressed the following issues:

  • CID 1321678
  • CID 1327386
  • CID 1364685
  • CID 1364686

though, they are rather minor issues anyway.

I don't think this requires any changelog entry.

Last edited 3 years ago by marcin (previous) (diff)

comment:11 Changed 3 years ago by stephen

  • Owner changed from UnAssigned to stephen

comment:12 Changed 3 years ago by stephen

  • Owner changed from stephen to marcin

Reviewed commits 1bea5e04b8a9a351f8be1d2c5dabe629e31b9be4 through 9ffe7d475f4281560c447411f89a54323770fa04

src/lib/util/versioned_csv_file.cc
VersionedCSVFile::setMinimumValidColumns. Strictly speaking, the deduction that the column name is not defined is only true if an isc::OutOfRange exception is thrown by getColumnIndex(); it is possible that another exception could be thrown. However, as that is extremely unlikely, the existing code is OK.

I agree that no ChangeLog entry is needed.

All OK, please merge

comment:13 Changed 3 years ago by marcin

  • Resolution set to fixed
  • Status changed from reviewing to closed

Merged with commit 017462e92ef3a3aa5411a97a794e15c9a0298755

Note: See TracTickets for help on using tickets.