Opened 4 years ago

Closed 4 years ago

#4247 closed defect (fixed)

HWAddr::source_ is never set by Pkt6 code when the MAC is extracted from a given source

Reported by: tmark Owned by: tmark
Priority: medium Milestone: Kea1.0
Component: dhcp6 Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

Pkt6 logic should set the source_ member of the HWAddr created via Pkt6::getMAC(). This method calls one or more of the Pkt6 methods that attempt to extract the MAC address. Currently, even whent the extraction is successful for a given source, the HWAddr::source_ memeber is never set and is therefore never persisted as part of the lease.

Subtickets

Change History (6)

comment:1 Changed 4 years ago by tmark

  • Owner set to tmark
  • Status changed from new to assigned

comment:2 Changed 4 years ago by tmark

  • Owner changed from tmark to Unassigned
  • Status changed from assigned to reviewing

Checks for the expected HWAddr:source_ value were added to the Pkt6 MAC extraction unit tests, and then the MAC extraction methods in Pkt and Pkt6 classes were modified to set the HWAddr::source_ of the extracted MAC to the appropriate value (see HWAddr::HWADDR_SOURCE...).

I would recommend the following ChangeLog:

1xxx.   [bug]       tmark
    The lease6 hardware address source value is now being properly populated.
    Prior to this the value stored with each IPv6 lease was always zero.
    (Trac #4247, git TBD)

comment:3 Changed 4 years ago by fdupont

  • Owner changed from Unassigned to fdupont
  • Status changed from reviewing to accepted

comment:4 Changed 4 years ago by fdupont

  • Owner changed from fdupont to mark
  • Status changed from accepted to reviewing

Code OK. Note IMHO we should stack a ticket for revisit/improve this code after the release.

comment:5 Changed 4 years ago by fdupont

  • Owner changed from mark to tmark

comment:6 Changed 4 years ago by tmark

  • Resolution set to fixed
  • Status changed from reviewing to closed

Changes merged with git # 27886dadcf9051dc622ee6fde586c27f3d431f8b
Added ChangeLog entry 1072.

ticket is complete.

Note: See TracTickets for help on using tickets.