Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#4201 closed defect (fixed)

DISTCHECK_CRYPTO_CONFIGURE_FLAG is incorrect with Botan

Reported by: fdupont Owned by: fdupont
Priority: low Milestone: Kea1.0-beta
Component: build system Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description (last modified by hschempf)

As Botan is the default we missed this but make distcheck gives at the configure phase:

configure: WARNING: unrecognized options: --with-botan

Of course it should be --with-botan-config.

Subtickets

Change History (8)

comment:1 Changed 4 years ago by fdupont

  • Owner set to fdupont
  • Status changed from new to accepted

comment:2 Changed 4 years ago by fdupont

  • Owner changed from fdupont to UnAssigned
  • Status changed from accepted to reviewing

Done. Ready for review.

comment:3 Changed 4 years ago by hschempf

  • Description modified (diff)
  • Milestone changed from Kea-proposed to Kea1.0

per nov 18 team meeting, accept 1.0 as low. could be done between beta and final.

comment:4 Changed 4 years ago by tomek

  • Owner changed from UnAssigned to tomek

comment:5 follow-up: Changed 4 years ago by tomek

  • Owner changed from tomek to fdupont

I did review the changes. They look ok. The distcheck failed for me for unrelated reasons (no rules to make src/lib/eval/parser.yy).

As the change is a simple 3 liner, which looks ok, I think it's ok to merge.

comment:6 in reply to: ↑ 5 Changed 4 years ago by fdupont

Replying to tomek:

The distcheck failed for me for unrelated reasons (no rules to make src/lib/eval/parser.yy).

=> parser.yy not in EXTRA_DIST? I remember to have fixed this one during #4088 merge.

comment:7 Changed 4 years ago by fdupont

  • Resolution set to fixed
  • Status changed from reviewing to closed

Merged. Closing.

comment:8 Changed 4 years ago by tomek

  • Milestone changed from Kea1.0 to Kea1.0-beta

Milestone renamed

Note: See TracTickets for help on using tickets.