Opened 9 years ago

Closed 9 years ago

#417 closed defect (fixed)

review: build error with clang++ for TSIG RDATA

Reported by: jinmei Owned by: jinmei
Priority: medium Milestone: y2 12 month milestone
Component: libdns++ Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity:
Sub-Project: Feature Depending on Ticket:
Estimated Difficulty: 0.0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

Could someone take a quick check on the attached patch?

clang++ doesn't like the current implementation of tsig_250.cc because it refers to TSIG::TSIGImpl (a private class internally defined in the TSIG class) outside the scope of the TSIG class. The attached patch avoids this error in a straightforward way.

I believe it's mostly trivial, but it may beyond the "too trivial" level, so I'm trying to get a review. If it cannot get reviewed quickly (within a day or so) I'll merge it anyway.

Subtickets

Attachments (1)

tsig.diff (2.2 KB) - added by jinmei 9 years ago.

Download all attachments as: .zip

Change History (4)

Changed 9 years ago by jinmei

comment:1 Changed 9 years ago by jinmei

  • Owner changed from jinmei to UnAssigned
  • Status changed from new to reviewing

comment:2 follow-up: Changed 9 years ago by vorner

  • Owner changed from UnAssigned to jinmei

It looks correct to me. I think you can merge it.

Anyway, I'm surprised the original code did compile with gcc.

comment:3 in reply to: ↑ 2 Changed 9 years ago by jinmei

  • Resolution set to fixed
  • Status changed from reviewing to closed

Replying to vorner:

It looks correct to me. I think you can merge it.

Thanks, committed. Closing ticket.

Anyway, I'm surprised the original code did compile with gcc.

I guess it was because the definition of the class (struct) is provided in the .cc file (not sure if it's compliant to the language standard though).

Note: See TracTickets for help on using tickets.