Opened 9 years ago

Closed 6 years ago

#413 closed defect (fixed)

loadzone thinks a label of digits is a TTL.

Reported by: jreed Owned by: muks
Priority: medium Milestone: bind10-1.2-release-freeze
Component: loadzone Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DNS Feature Depending on Ticket:
Estimated Difficulty: 0.0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

BIND 9 loads this fine, but b10-loadzone thinks "1" is a TTL.

@       IN      SOA     server  email   1 2 3 4 5
@       IN      NS      ns1
ns1     IN      A       127.0.0.1
ns1.1   IN      A       127.0.0.3
ns2.1   IN      A       127.0.0.4
1       IN      NS      ns1.1
1       IN      NS      ns2.1

For example:

sqlite> select * from records ;
1|1|tld.|tld.|5|SOA||server.tld. email.tld. 1 2 3 4 5
2|1|tld.|tld.|5|NS||ns1.tld.
3|1|ns1.tld.|tld.ns1.|5|A||127.0.0.1
4|1|ns1.1.tld.|tld.1.ns1.|5|A||127.0.0.3
5|1|ns2.1.tld.|tld.1.ns2.|5|A||127.0.0.4
6|1|ns2.1.tld.|tld.1.ns2.|1|NS||ns1.1.tld.
7|1|ns2.1.tld.|tld.1.ns2.|1|NS||ns2.1.tld.

RFC1034 says "The start of the line gives the owner of the RR. If a line begins with a blank, then the owner is assumed to be the same as that of the previous RR." And RFC1101 allows a label to be a number (so don't have to start with a letter per RFC1034).

Subtickets

Change History (6)

comment:1 Changed 8 years ago by jreed

  • Defect Severity set to N/A
  • Sub-Project set to DNS

comment:2 Changed 6 years ago by shane

  • Milestone set to Sprint-20131015
  • Summary changed from loadzone thinks a label of digits is a TTL. to [kean] loadzone thinks a label of digits is a TTL.

This should be fixed, as the zone loader is completely rewritten.

We should check our tests to see if this is checked for, and if not write a new test to confirm that it works.

comment:3 Changed 6 years ago by kean

  • Summary changed from [kean] loadzone thinks a label of digits is a TTL. to loadzone thinks a label of digits is a TTL.

comment:4 Changed 6 years ago by muks

  • Owner set to UnAssigned
  • Status changed from new to reviewing

A master loader unittest has been added for this scenario. The implementation is fine now.

Up for review.

comment:5 Changed 6 years ago by shane

  • Owner changed from UnAssigned to muks

Looks good, please commit! :)

comment:6 Changed 6 years ago by muks

  • Resolution set to fixed
  • Status changed from reviewing to closed

Merged to master branch in commit 5f56f59e4beab346584b53e8e80973f39ced5cff:

* 9ffc91f [413] Add a unittest for numeric owner names in master files

Resolving as fixed. Thank you for the review Shane.

Note: See TracTickets for help on using tickets.