Opened 4 years ago

Last modified 4 years ago

#4124 new enhancement

Make eval::Expression and class which can store the string expression as well as the token stack

Reported by: tmark Owned by:
Priority: medium Milestone: Outstanding Tasks
Component: dhcp Version: git
Keywords: eval classification Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description (last modified by tomek)

It would simplify logging/diagnostics if we morphed Expression from a typedef'd vector to a class which can store the string version of the expression from which its vector of tokens is constructed.

Subtickets

Change History (3)

comment:1 Changed 4 years ago by fdupont

It is not necessary as it is easy to decompile an Expression, cf #4115 (I am just working on it to update it to the new no-quote syntax).

comment:2 Changed 4 years ago by tomek

  • Description modified (diff)

I'm with Thomas on this one. I think it may be useful to pass around if it's a class, even if there's not much more than the typedefed vector.

comment:3 Changed 4 years ago by tomek

  • Milestone changed from Kea-proposed to Outstanding Tasks

It was discussed again during 2016-03-03 call and the decisino to move it to outstanding still stands. We can't accept new tickets in 1.1, because we already have lots of tickets there, unless something is critical.

Note: See TracTickets for help on using tickets.