Opened 5 years ago

Closed 5 years ago

Last modified 4 years ago

#4061 closed enhancement (complete)

use isc::asiolink::IOAddress predicates

Reported by: fdupont Owned by: fdupont
Priority: low Milestone: Kea1.0-beta
Component: Unclassified Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

Some codes define a ZERO_ADDRESS and compare with it. In fact the isc::asiolink::IOAddress class provides some predicate methods as in this case isV4Zero() which does the job in a better way!

Subtickets

Change History (6)

comment:1 Changed 5 years ago by fdupont

cfg_subnets4.cc in dhcpsrc lib should be cleaned up.

comment:2 Changed 5 years ago by fdupont

  • Owner changed from fdupont to UnAssigned
  • Status changed from new to reviewing

Done. Ready for review.

comment:3 Changed 5 years ago by stephen

  • Milestone changed from Kea-proposed to Kea1.0
  • Owner changed from UnAssigned to fdupont

Reviewed commit 5310305fea40d3f55d7a32a6383a888883101916

src/lib/dhcpsrv/cfg_subnets4.cc
In CfgSubnet4::selectSubnet line 68, "address" should be set to IOAddress::IPV4_ZERO_ADDRESS, not the V6 zero address.

Apart from that, all is OK. Please merge after correcting it, I don't need to see it again.

This change is small and not user-visible: I don't think it needs a ChangeLog entry.

comment:4 Changed 5 years ago by fdupont

Merged. Closing...

comment:5 Changed 5 years ago by fdupont

  • Resolution set to complete
  • Status changed from reviewing to closed

comment:6 Changed 4 years ago by tomek

  • Milestone changed from Kea1.0 to Kea1.0-beta

Milestone renamed

Note: See TracTickets for help on using tickets.