Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#4046 closed defect (fixed)

Header file not installed

Reported by: stephen Owned by: stephen
Priority: low Milestone: Kea1.0-beta
Component: Unclassified Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

The file log/message_dictionary.h is not included in the header files installed on the target system.

See https://lists.isc.org/pipermail/kea-dev/2015-September/000469.html

Subtickets

Change History (8)

comment:1 Changed 4 years ago by stephen

  • Owner set to stephen
  • Status changed from new to accepted

comment:2 Changed 4 years ago by stephen

  • Owner changed from stephen to UnAssigned
  • Status changed from accepted to assigned

Ready to review.

A closer look at message_initializer.h, showed that the only reason for the inclusion of message_dictionary.h was to get the definition of MessageDictionaryPtr, a typedef for boost::shared_ptr<MessageDictionary>.

As only a declaration - rather than a definition - of a class is needed for it to be used as a template argument to boost::shared_ptr, a declaration of MessageDictionary is made in message_initializer.h and the inclusion of message_dictionary.h removed. This eliminates the requirement to copy message_dictionary.h to the install directory.

As the MessageDictionary class contains methods to replace messages in the dictionary, at some point we may want to make it available to hooks authors. At the moment though, not supplying it means that there is one less thing to worry about when deciding whether two versions of Kea are compatible from a hooks point of view.

Suggested ChangeLog entry is

Replace #include of message_dictionary.h in message_initializer.h
with a declaration of the MessageDictionary class.

comment:3 Changed 4 years ago by stephen

  • Status changed from assigned to reviewing

comment:4 Changed 4 years ago by hschempf

  • Milestone changed from Kea-proposed to Kea1.0

per team meeting 23 sept, move to 1.0

comment:5 Changed 4 years ago by fdupont

  • Owner changed from UnAssigned to fdupont
  • Status changed from reviewing to accepted

comment:6 Changed 4 years ago by fdupont

  • Owner changed from fdupont to stephen
  • Status changed from accepted to reviewing

Patch (and ChangeLog proposal) OK.

comment:7 Changed 4 years ago by stephen

  • Resolution set to fixed
  • Status changed from reviewing to closed

Merged in commit 9f1801b4326f62632a7c9f0aa939d58f120c10e8

comment:8 Changed 4 years ago by tomek

  • Milestone changed from Kea1.0 to Kea1.0-beta

Milestone renamed

Note: See TracTickets for help on using tickets.