Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#4045 closed defect (fixed)

cppcheck warnings

Reported by: fdupont Owned by: fdupont
Priority: low Milestone: Kea1.0-beta
Component: Unclassified Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

cf. https://jenkins.isc.org/job/FreeBSD10.1_32_cpp-check/lastBuild/cppcheckResult/
(It seems #3911 introduced too many new warnings... I apologize because I thought about compiler warnings and forgot cppcheck...).
(BTW there could be a pending ticket about the iterator old warning).

Subtickets

Change History (6)

comment:1 Changed 4 years ago by fdupont

  • Owner set to fdupont
  • Status changed from new to accepted

comment:2 Changed 4 years ago by fdupont

  • Owner changed from fdupont to UnAssigned
  • Status changed from accepted to reviewing

leave the 2 issues in dns/master_loader.cc (it will be simpler to obsolete the whole file than to fix it). Other errors were fixed.
Ready for review.

comment:3 Changed 4 years ago by stephen

  • Owner changed from UnAssigned to stephen

comment:4 Changed 4 years ago by stephen

  • Milestone changed from Kea-proposed to Kea1.0
  • Owner changed from stephen to fdupont

Reviewed commit 803e7a8f71c91655119b877e266514a84c93271d

These changes are trivial and not user-visible. I don't think they need a ChangeLog entry.

All OK, please merge.

comment:5 Changed 4 years ago by fdupont

  • Resolution set to fixed
  • Status changed from reviewing to closed

Merged. Closing.

comment:6 Changed 4 years ago by tomek

  • Milestone changed from Kea1.0 to Kea1.0-beta

Milestone renamed

Note: See TracTickets for help on using tickets.