Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#4026 closed defect (fixed)

LoggingTest.basicSpec fails

Reported by: fdupont Owned by: fdupont
Priority: high Milestone: Kea1.0-beta
Component: Unclassified Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

LoggingTest?.basicSpec fails because it uses the TEST_DATA_BUILDDIR directory when it should use something related to srcdir (vs builddir). This issue was introduced by #3752 but I prefer to give an opportunity to cleanup Makefile.am CPPFLAGS defines than to reopen the faulty ticket.
Priority medium as it breaks distcheck.

Subtickets

Change History (7)

comment:1 Changed 4 years ago by fdupont

  • Owner set to fdupont
  • Status changed from new to accepted

I interpret the creation of the #4030 duplicate as this ticket being urgent...

comment:2 Changed 4 years ago by fdupont

  • Owner changed from fdupont to UnAssigned
  • Status changed from accepted to reviewing

Done. Ready for review.

comment:3 Changed 4 years ago by tmark

  • Owner changed from UnAssigned to tmark

comment:4 Changed 4 years ago by tmark

  • Owner changed from tmark to fdupont

I was able to reproduce the distcheck failure under Centos 6.4 using master, and then verify that your patch does indeed fix it.

This change does require a ChangeLog entry, see previous log entries for distcheck corrections for guidance.

Beyond that it is ready to merge.

comment:5 Changed 4 years ago by fdupont

  • Resolution set to fixed
  • Status changed from reviewing to closed

Merged with this log entry:
The logging spec file was searched in the build tree when it was in the source tree so distcheck (where they differ) failed.

comment:6 Changed 4 years ago by hschempf

  • Milestone changed from Kea-proposed to Kea1.0

comment:7 Changed 4 years ago by tomek

  • Milestone changed from Kea1.0 to Kea1.0-beta

Milestone renamed

Note: See TracTickets for help on using tickets.