Opened 5 years ago

Closed 5 years ago

Last modified 4 years ago

#4010 closed enhancement (wontfix)

reconsider mutexes in log library

Reported by: fdupont Owned by: fdupont
Priority: medium Milestone: Kea1.0-beta
Component: logging Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

cf. #4008: src/lib/log uses Mutex objects.
IMHO it should not so we have to choose between:

  • remove the mutex stuff
  • define a mono-thread version.

BTW I am in favor of the first (remove the code) as it is simpler.
I keep a medium priority as #4008 depends on it.

Subtickets

Change History (6)

comment:1 follow-up: Changed 5 years ago by fdupont

  • Owner set to fdupont
  • Status changed from new to accepted

I implement in trac4010 the first solution (no mutex as Kea is not multi-threaded).

comment:2 in reply to: ↑ 1 Changed 5 years ago by marcin

Replying to fdupont:

I implement in trac4010 the first solution (no mutex as Kea is not multi-threaded).

Please don't. We have decided on the Kea weekly call yesterday that this ticket goes to outstanding. One of the reasons is that Kea will likely become multithreaded. For example: Kea 1.0 will have a worker thread kicking off periodic timers for lease expiration and decline.

comment:3 Changed 5 years ago by fdupont

Oops, I am just compiling a Kea without the thread utils. Fortunately I've committed nothing in the branch. BTW even it is not trivial the thread utils were ported to WIN32 so there is no issue with it...
I strongly suggest to update #4008 too.

(I can't connect to the jabber server?)

comment:4 Changed 5 years ago by fdupont

  • Resolution set to wontfix
  • Status changed from accepted to closed

Tested with removal of everything related to thread or mutex in src/lib/log + threads commented in src/lib/util/Makefile.am SUBDIRS. So the dependency is fully identified and this ticket can be rejected.

comment:5 Changed 5 years ago by hschempf

  • Milestone changed from Kea-proposed to Kea1.0

comment:6 Changed 4 years ago by tomek

  • Milestone changed from Kea1.0 to Kea1.0-beta

Milestone renamed

Note: See TracTickets for help on using tickets.