Opened 9 years ago

Closed 9 years ago

#399 closed task (fixed)

zone table class for in memory data source

Reported by: jinmei Owned by: jinmei
Priority: medium Milestone: y2 12 month milestone
Component: data source Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity:
Sub-Project: Feature Depending on Ticket:
Estimated Difficulty: 0.0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

From the sprint planning sheet:

  • This will be a straightforward container of in memory data source instances.
  • It provides a find method that accepts a domain name (= query name) and returns the best matching data source instance, if any.

Subtickets

Change History (6)

comment:1 Changed 9 years ago by jinmei

  • Owner changed from jinmei to UnAssigned
  • Status changed from new to reviewing

branches/trac399 is ready for review.

I've introduced an additional "Zone" class in addition to the zone table class, the main goal of this ticket. This is because I didn't know how the underlying data source looks like yet, and also because I suspected we'd need this level of abstraction anyway.

At the moment I didn't provide python wrappers, because I was not sure if we need them for our initial goal, and also because I wanted to keep the branch as small as possible for easier review.

The diff should be quite trivial.

comment:2 Changed 9 years ago by zzchen_pku

  • Owner changed from UnAssigned to zzchen_pku

comment:3 follow-up: Changed 9 years ago by zzchen_pku

  • Owner changed from zzchen_pku to jinmei

Looks okay, only two minor questions:

src/lib/datasrc/zonetable.cc
It seems variable "qname" in find() has never been used.

src/lib/datasrc/tests/zonetable_unittest.cc
Maybe we can add more zones whose origins are super domains of the given name for validating longest match(For example, add "com" and "example.com", then query "www.example.com").

comment:4 in reply to: ↑ 3 Changed 9 years ago by jinmei

  • Owner changed from jinmei to zzchen_pku

Replying to zzchen_pku:

Looks okay, only two minor questions:

src/lib/datasrc/zonetable.cc
It seems variable "qname" in find() has never been used.

Good catch, fixed in r3585.

src/lib/datasrc/tests/zonetable_unittest.cc
Maybe we can add more zones whose origins are super domains of the given name for validating longest match(For example, add "com" and "example.com", then query "www.example.com").

Added it: r3586.

I've also noticed minor errors in doxygen comments, and fixed them in r3587.

Finally, I realized I didn't propose a changelog entry for this ticket. I'm not sure if we need one for this type of intermediate change, but I'm going to propose it anyway (maybe we should discuss it in the bi-weekly call as a general matter).

  115.? [func]		jinmei
	src/lib/datasrc: added new zone and zone table classes for the
	support of in memory data source.  This is an intermediate step to
	the bigger feature, and is not yet actually usable in practice.
	(Trac #399, svn rTBD)

Is it now okay to commit?

comment:5 follow-up: Changed 9 years ago by zzchen_pku

  • Owner changed from zzchen_pku to jinmei

Okay, please go ahead and merge.

comment:6 in reply to: ↑ 5 Changed 9 years ago by jinmei

  • Resolution set to fixed
  • Status changed from reviewing to closed

Replying to zzchen_pku:

Okay, please go ahead and merge.

Thanks, committed, closing ticket.

Note: See TracTickets for help on using tickets.