Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#3986 closed enhancement (complete)

Implement lease4_decline hook

Reported by: tomek Owned by: tomek
Priority: medium Milestone: Kea1.0-beta
Component: hooks Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

See DeclineDesign for details.

Subtickets

Change History (7)

comment:1 Changed 5 years ago by tomek

  • Component changed from dhcp4 to hooks

comment:2 Changed 4 years ago by tomek

  • Owner set to tomek
  • Status changed from new to assigned

comment:3 Changed 4 years ago by tomek

  • Owner changed from tomek to UnAssigned
  • Status changed from assigned to reviewing

The code is now ready for review.

Proposed ChangeLog entry:

10XX.	[func]		tomek
	A new hook point lease4_decline has been added. It is called when
	the DHCPv4 server is about to decline a lease as a result of
	processing incoming DHCPDECLINE message.
	(Trac #3986, git tbd)

Couple tips for a reviewer:

  1. This code is branched from trac3499, so to get all changes, you can use git diff trac3499...trac3986
  2. The diff is 3,3k lines long, but majority of that is code move. Lots of hook unit-tests were moved from dhcp4_srv_unittest.cc to a new file hooks_unittest.cc. That move was done as a separate commit, so perhaps doing the review commit by commit would be easier.

comment:4 Changed 4 years ago by fdupont

  • Owner changed from UnAssigned to fdupont

comment:5 follow-up: Changed 4 years ago by fdupont

  • Owner changed from fdupont to tomek

Fixed spelling errors (so please pull). BTW some should be from trac3499...

In dhcp4_hooks.dox: as is -> as it is

in HooksDhcpv4SrvTest HooksDecline?: lease mgr -> lease manager (and same for HooksDeclineDrop? where the comment is copied)

Update the HooksDhcpv4SrvTest HooksDeclineDrop? (it was copied from HooksDecline?).

I am running Jenkins on the branch. As all concerns are about comments if Jenkins is happy please merge.

comment:6 in reply to: ↑ 5 Changed 4 years ago by tomek

  • Resolution set to complete
  • Status changed from reviewing to closed

Replying to fdupont:

Fixed spelling errors (so please pull). BTW some should be from trac3499...

Pulled. Thanks.

In dhcp4_hooks.dox: as is -> as it is

Fixed.

in HooksDhcpv4SrvTest HooksDecline?: lease mgr -> lease manager (and same for HooksDeclineDrop? where the comment is copied)

Fixed in both tests.

Update the HooksDhcpv4SrvTest HooksDeclineDrop? (it was copied from HooksDecline?).

Updated test description.

I am running Jenkins on the branch. As all concerns are about comments if Jenkins is happy please merge.

Thanks for the review. Code merged. Closing ticket.

comment:7 Changed 4 years ago by tomek

  • Milestone changed from Kea1.0 to Kea1.0-beta

Milestone renamed

Note: See TracTickets for help on using tickets.