Opened 9 years ago
Last modified 4 years ago
#398 new enhancement
we should use more specific tests than EXPECT_TRUE
Reported by: | jinmei | Owned by: | |
---|---|---|---|
Priority: | low | Milestone: | Outstanding Tasks |
Component: | documentation | Version: | git |
Keywords: | Cc: | ||
CVSS Scoring: | Parent Tickets: | ||
Sensitive: | no | Defect Severity: | N/A |
Sub-Project: | DHCP | Feature Depending on Ticket: | |
Estimated Difficulty: | 0.0 | Add Hours to Ticket: | 0 |
Total Hours: | 0 | Internal?: | no |
Description
See http://bind10.isc.org/ticket/365#comment:8
In general, when we do
EXPECT_TRUE(a <op> b);
it's better to be changed to:
EXPECT_<op>(a, b);
because when the test fails the latter will provide more detailed information (the values of a and b).
Subtickets
Change History (4)
comment:1 Changed 9 years ago by stephen
- Milestone feature backlog item deleted
comment:2 Changed 5 years ago by tomek
- Milestone set to Remaining BIND10 tickets
comment:3 Changed 5 years ago by tomek
- Component changed from Unclassified to documentation
- Defect Severity set to N/A
- Milestone changed from Remaining BIND10 tickets to DHCP Outstanding Tasks
- Sub-Project set to DHCP
- Version set to git
This is more like a postulate. It is unfeasible to go through 2,5k unit-tests and update them all.
However, it would make sense to add this to coding guidelines.
comment:4 Changed 4 years ago by tomek
- Milestone changed from DHCP Outstanding Tasks to Outstanding Tasks
Milestone renamed
Note: See
TracTickets for help on using
tickets.
Milestone feature backlog item deleted