Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#3967 closed task (complete)

Provide upgrade scripts to the 4.0 MySQL schema version

Reported by: marcin Owned by: tmark
Priority: high Milestone: Kea1.0-beta
Component: dhcp Version: git
Keywords: expiration Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

See Design for details.

Subtickets

Change History (8)

comment:1 Changed 5 years ago by marcin

  • Milestone changed from Kea-proposed to Kea1.0

comment:2 Changed 5 years ago by marcin

It should be considered within this ticket to update the lease_dump scripts to join with the lease_hw_source and lease_state tables to return the values in more user friendly form.

comment:3 Changed 5 years ago by tmark

  • Owner set to tmark
  • Status changed from new to assigned

comment:4 Changed 4 years ago by tmark

  • Owner changed from tmark to UnAssigned
  • Status changed from assigned to reviewing

After adding the new upgrade script, I updated the lease6 dump to lookup the lease_hwaddr_source as suggested. It was already looking up the state values.

I suggest the following ChangeLog entry:

1xxx.   [func]      tmark
    kea-admin now supports upgrading from MySQL schema version 3.0
    to 4.0.  In addition, the lease6 data dump now contains the         
    text label for lease_hwaddr_source column rather than its
    numeric value.
    (Trac #3967, git TBD)

comment:5 Changed 4 years ago by marcin

  • Owner changed from UnAssigned to marcin

comment:6 Changed 4 years ago by marcin

  • Owner changed from marcin to tmark

Reviewed commit 52476f730aa58bff6cb2506679cf3eef422a1eeb

src/bin/admin/scripts/mysql/Makefile.am
It strikes me that instead of repeating all script files for the EXTRA_DIST you could simply do

EXTRA_DIST = $(sqlscripts_DATA)

Otherwise, your changes look good. I the database upgrade to version 4.0 on OS-X and it worked fine.

Regardless of what you decide about the comment I made above, you can go ahead and merge.

comment:7 Changed 4 years ago by tmark

  • Resolution set to complete
  • Status changed from reviewing to closed

I took your suggestion, not sure why I didn't see it myself. Good catch.

Ticket is merged in with git 2e13ac3b0b278faabe338b00ffee8259c13f5342.

Added ChangeLog? entry 1023.

comment:8 Changed 4 years ago by tomek

  • Milestone changed from Kea1.0 to Kea1.0-beta

Milestone renamed

Note: See TracTickets for help on using tickets.