Opened 5 years ago

Closed 5 years ago

#3949 closed defect (fixed)

kea-dhcp6.packets logging twice message DHCP6_RESPONSE_DATA

Reported by: wlodekwencel Owned by: marcin
Priority: low Milestone: Kea0.9.2
Component: logging Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 1 Internal?: no

Description

Logger kea-dhcp6.packets every time when it saves DHCP6_RESPONSE_DATA message is doing it twice.

e.g:

2015-07-14 03:18:48.612 DEBUG [kea-dhcp6.packets/3822] DHCP6_RESPONSE_DATA responding with packet type 2 data is localAddr=[ff02::1:2]:547 remoteAddr=[fe80::250:56ff:fec0:8]:546
msgtype=2, transid=0x9e913d
type=00001, len=00014: 00:01:00:01:55:a4:e2:05:00:0c:29:c9:56:08
type=00002, len=00014: 00:01:00:01:1c:f7:36:96:00:0c:29:c9:56:fe
type=00003(IA_NA), len=00040: iaid=65757, t1=1000, t2=2000,
options:
  type=00005(IAADDR), len=00024: address=3000::1, preferred-lft=3000, valid-lft=4000

2015-07-14 03:18:48.612 DEBUG [kea-dhcp6.packets/3822] DHCP6_RESPONSE_DATA responding with packet type 2 data is localAddr=[ff02::1:2]:547 remoteAddr=[fe80::250:56ff:fec0:8]:546
msgtype=2, transid=0x9e913d
type=00001, len=00014: 00:01:00:01:55:a4:e2:05:00:0c:29:c9:56:08
type=00002, len=00014: 00:01:00:01:1c:f7:36:96:00:0c:29:c9:56:fe
type=00003(IA_NA), len=00040: iaid=65757, t1=1000, t2=2000,
options:
  type=00005(IAADDR), len=00024: address=3000::1, preferred-lft=3000, valid-lft=4000
2015-07-14 03:18:53.238 DEBUG [kea-dhcp6.packets/3902] DHCP6_RESPONSE_DATA responding with packet type 7 data is localAddr=[ff02::1:2]:547 remoteAddr=[fe80::250:56ff:fec0:8]:546
msgtype=7, transid=0xaa8fb3
type=00001, len=00014: 00:01:00:01:55:a4:e2:05:00:0c:29:c9:56:08
type=00002, len=00014: 00:01:00:01:1c:f7:36:96:00:0c:29:c9:56:fe
type=00003(IA_NA), len=00063: iaid=65757, t1=0, t2=0,
options:
  type=00013, len=00047: Success(0) "Lease released. Thank you, please come again."
type=00013, len=00041: Success(0) "Summary status for all processed IA_NAs"

2015-07-14 03:18:53.238 DEBUG [kea-dhcp6.packets/3902] DHCP6_RESPONSE_DATA responding with packet type 7 data is localAddr=[ff02::1:2]:547 remoteAddr=[fe80::250:56ff:fec0:8]:546
msgtype=7, transid=0xaa8fb3
type=00001, len=00014: 00:01:00:01:55:a4:e2:05:00:0c:29:c9:56:08
type=00002, len=00014: 00:01:00:01:1c:f7:36:96:00:0c:29:c9:56:fe
type=00003(IA_NA), len=00063: iaid=65757, t1=0, t2=0,
options:
  type=00013, len=00047: Success(0) "Lease released. Thank you, please come again."
type=00013, len=00041: Success(0) "Summary status for all processed IA_NAs"

Subtickets

Change History (6)

comment:1 Changed 5 years ago by marcin

  • Milestone changed from Kea-proposed to Kea0.9.2
  • Priority changed from medium to low

Moving to 0.9.2 per Kea call on 7/15/2015

comment:2 Changed 5 years ago by marcin

  • Owner set to marcin
  • Status changed from new to assigned

comment:3 Changed 5 years ago by marcin

  • Owner changed from marcin to UnAssigned
  • Status changed from assigned to reviewing

I removed the extraneous log message. I don't think that this requires any change log entry.

comment:4 Changed 5 years ago by tmark

  • Owner changed from UnAssigned to tmark

comment:5 Changed 5 years ago by tmark

  • Owner changed from tmark to marcin
  • Total Hours changed from 0 to 1

Your changes look fine, though I would disagree about the need for a ChangeLog entry. It is possible that people have adapted to the double output or at least have been annoyed by it. It's a pretty user-visible change if one is debugging system logs.

How about something like this?

9xx.    [bug]       marcin
    Eliminated extraneous debug-level DHCP6_RESPONSE_DATA entry from the
    DHCPv6 server log output.  Prior to this the server was logging 
    each response twice.
    (Trac #3949, git TBD)

comment:6 Changed 5 years ago by marcin

  • Resolution set to fixed
  • Status changed from reviewing to closed

Merged with commit 023973cbce44e5fb92a2bc45e69f2786d5152091

I also added the ChangeLog entry.

Note: See TracTickets for help on using tickets.