Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#3922 closed enhancement (complete)

Stopwatch copy constructor

Reported by: fdupont Owned by: fdupont
Priority: low Milestone: Kea0.9.2
Component: Unclassified Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

Cppcheck complains about Stopwatch class declaration (in lib/util/stopwatch.h): 'class Stopwatch' does not have a copy constructor which is recommended since the class contains a pointer to allocated memory.

Subtickets

Change History (8)

comment:1 Changed 5 years ago by fdupont

I leave this one. IMHO we should try first to make in not copyable...

comment:2 Changed 5 years ago by fdupont

  • Owner set to fdupont
  • Status changed from new to accepted

BTW I checked my proposal and it seems to work perfectly.

comment:3 Changed 5 years ago by fdupont

  • Type changed from defect to enhancement

comment:4 Changed 5 years ago by fdupont

  • Owner changed from fdupont to UnAssigned
  • Status changed from accepted to reviewing

Done. Ready for review.

comment:5 Changed 5 years ago by stephen

  • Owner changed from UnAssigned to stephen

comment:6 Changed 5 years ago by stephen

  • Owner changed from stephen to fdupont

Reviewed commit 651f711cc3289fd0d81b8a1af745dcea1b0f8e90

All OK, please merge. This trivial change does not need a ChangeLog entry.

comment:7 Changed 5 years ago by fdupont

  • Resolution set to complete
  • Status changed from reviewing to closed

Merged, closing.

comment:8 Changed 5 years ago by hschempf

  • Milestone changed from Kea-proposed to Kea0.9.2
Note: See TracTickets for help on using tickets.