Opened 4 years ago

Last modified 3 years ago

#3915 reviewing enhancement

Add temporary state in host reservation

Reported by: fdupont Owned by: UnAssigned
Priority: low Milestone: Outstanding Tasks
Component: securedhcp Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description (last modified by tomek)

The idea is to add/attach mutable temporary (i.e., extend == lifetime of the server process) state to host reservation structure. One candidate to go into this state is the last received and transmitted timestamps of secureDHCPv6.
The only burden is to create this state in the constructor and destroy it in the destructor. The mutability should be handled by using a (smart) pointer to a structure containing the state.

Subtickets

Change History (10)

comment:1 Changed 4 years ago by fdupont

  • Owner set to fdupont
  • Status changed from new to accepted

I get the ticket but please classify it for after 0.9.2...

comment:2 Changed 4 years ago by fdupont

Implemented the proposal (which is needed for secure DHCPv6). The example is in comments with a const for the property setter
(proof of mutability).
Ready for review.

comment:3 Changed 4 years ago by fdupont

  • Owner changed from fdupont to UnAssigned
  • Status changed from accepted to reviewing

comment:4 Changed 4 years ago by marcin

I disagree with extending the Host class in this way, unless the introduced properties will be a part of the host reservation information and will be stored in the host reservation database. Please refer to the kea-dev archives for further details: https://lists.isc.org/pipermail/kea-dev/2015-June/000382.html

comment:5 Changed 4 years ago by fdupont

  • Owner changed from UnAssigned to fdupont
  • Status changed from reviewing to accepted

Take the ticket to rebase and address Marcin's comment.

comment:6 Changed 4 years ago by fdupont

  • Owner changed from fdupont to UnAssigned
  • Status changed from accepted to reviewing

Branch trac3915a is ready for review. BTW if you need an application please refer to sedhcpv6a branch.

comment:7 Changed 4 years ago by tomek

  • Milestone changed from Kea-proposed to DHCP Outstanding Tasks

comment:8 Changed 4 years ago by fdupont

  • Component changed from Unclassified to securedhcp

comment:9 Changed 4 years ago by tomek

  • Milestone changed from DHCP Outstanding Tasks to Outstanding Tasks

Milestone renamed

comment:10 Changed 3 years ago by tomek

  • Description modified (diff)

I can't publicly tell you which, but there are other implementations that allow attaching context to about any structure (reservations, leases, subnets, pools etc.). This is a great way to solve this.

Context can be any (key,value) pair.

Note: See TracTickets for help on using tickets.