Opened 5 years ago

Closed 3 years ago

Last modified 3 years ago

#3903 closed enhancement (worksforme)

Graceful control socket handling in configuration rollback

Reported by: tomek Owned by: UnAssigned
Priority: low Milestone: Kea1.2-final
Component: remote-management Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: Mozilla Feature Depending on Ticket: 5150
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description (last modified by tomek)

As pointed out in http://kea.isc.org/ticket/3880#comment:6:

I do not see tests for invalid command socket configuration handling
In particular, "rollback". If I have the a good config which configures
the command socket, followed by a bad config, does the command socket get
re-opened on rollback?

Side note: current Kea code has similar issue with DHCP sockets and with hook librarie: what to do when DHCP socket reopening failed or when reloading hook libraries failed.

Subtickets

Change History (17)

comment:1 Changed 5 years ago by hschempf

  • Milestone changed from Kea-proposed to Kea0.9.2
  • Priority changed from medium to low

comment:2 Changed 5 years ago by fdupont

  • Summary changed from Graceful control socket handling in configration rollback to Graceful control socket handling in configuration rollback

comment:3 Changed 5 years ago by marcin

  • Milestone changed from Kea0.9.2 to Kea1.1

Not accepting in 1.0 as per 1.0 tickets scrub on 07/31/2015.

comment:4 Changed 4 years ago by tomek

  • Milestone changed from Kea1.1 to DHCP Outstanding Tasks

comment:5 Changed 4 years ago by tomek

  • Milestone changed from DHCP Outstanding Tasks to Outstanding Tasks

Milestone renamed

comment:6 Changed 3 years ago by tomek

  • Description modified (diff)
  • Milestone changed from Outstanding Tasks to Kea1.2

comment:7 Changed 3 years ago by tomek

  • Component changed from configuration to remote-management

comment:8 Changed 3 years ago by fdupont

We have to check this. As far as I know rollback can come back to a sane config.

comment:9 Changed 3 years ago by tomek

  • Sub-Project changed from DHCP to Mozilla

comment:10 Changed 3 years ago by fdupont

  • Owner set to fdupont
  • Status changed from new to accepted

comment:11 Changed 3 years ago by fdupont

The code is there so it is only a new unit test issue.

comment:12 Changed 3 years ago by fdupont

  • Feature Depending on Ticket set to 5150

In fact the required new unit test will be far easier to write with test-config command internal implementation because it is the easier way to force a rollback. So making a dependency on #5150.

comment:13 Changed 3 years ago by fdupont

  • Owner changed from fdupont to UnAssigned
  • Status changed from accepted to reviewing

IMHO the code added for the set-config command provides the right behavior and associated unit tests are enough. So I propose to close this ticket.
I put it on the review queue but there is no associated branch and the suggested resolution is "worksforme'.

comment:14 Changed 3 years ago by tomek

  • Milestone changed from Kea1.2 to Kea1.2-final

Code freeze for 1.2-beta. Moving all remaining open tickets to 1.2-final.

comment:15 Changed 3 years ago by tomek

  • Resolution set to worksforme
  • Status changed from reviewing to closed

Ok, going with Francis' proposed solution. Closing as worksforme.

comment:16 Changed 3 years ago by tomek

  • Milestone changed from Kea1.2-final to Kea1.3

As discussed on 2017-04-13 Kea call, moving all low review tickets that have not started review yet to Kea1.3.

comment:17 Changed 3 years ago by tomek

  • Milestone changed from Kea1.3 to Kea1.2-final
Note: See TracTickets for help on using tickets.