Opened 5 years ago

Closed 5 years ago

#3881 closed defect (fixed)

HooksDhcpv4SrvTest, subnet4SelectSimple issue

Reported by: fdupont Owned by: tomek
Priority: high Milestone: Kea0.9.2-beta
Component: hooks Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: Medium
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

The HooksDhcpv4SrvTest.subnet4SelectSimple unit test is wrong (it doesn't commit the config) so with the ASSERT added by #3868 it no longer passes (before it passed or crashed depending on out of bound access check).
(high priority as it breaks jenkins tests)

Subtickets

Change History (5)

comment:1 Changed 5 years ago by fdupont

  • Owner set to fdupont
  • Status changed from new to accepted

comment:2 Changed 5 years ago by fdupont

Bug fixed, branch ready for review.
BTW what to put in the ChangeLog?

comment:3 Changed 5 years ago by fdupont

  • Owner changed from fdupont to UnAssigned
  • Status changed from accepted to reviewing

comment:4 Changed 5 years ago by tomek

  • Owner changed from UnAssigned to tomek

comment:5 Changed 5 years ago by tomek

  • Component changed from Unclassified to hooks
  • Milestone changed from Kea-proposed to Kea0.9.2
  • Resolution set to fixed
  • Status changed from reviewing to closed

Code reviewed. Looks good. Tests passed on Ubuntu 14.04 x64. Merging to master.

I also added a very brief ChangeLog? entry.

Note: See TracTickets for help on using tickets.