Opened 4 years ago

Last modified 3 years ago

#3843 reviewing enhancement

cc/session.cc and local/unix sockets

Reported by: fdupont Owned by: UnAssigned
Priority: low Milestone: Outstanding Tasks
Component: Unclassified Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description (last modified by tomek)

cc/session.cc uses local/unix sockets which is not portable on systems without them.

The choice is between:

  • add an option in the code with inet sockets (bound to the local address).
  • keep it private for WIN32 (or any new systems without local/unix address support).

I believe the second solution is better but I'd like to collect opinions first and get a branch name in case there will be a rough consensus for the first one.

Subtickets

Change History (5)

comment:1 Changed 4 years ago by fdupont

  • Owner set to UnAssigned
  • Status changed from new to reviewing

comment:2 Changed 4 years ago by fdupont

I'll change this in another ticket into: the type of a socket (you can say file descriptor if (and only if) you know it is a clear abuse) is not an int or a SOCKET but a asio::detail::socket_type . Of course this requires to have enough asio includes but it is a common case in the networking code...

comment:3 Changed 4 years ago by tomek

  • Milestone changed from Kea-proposed to DHCP Outstanding Tasks

comment:4 Changed 4 years ago by tomek

  • Milestone changed from DHCP Outstanding Tasks to Outstanding Tasks

Milestone renamed

comment:5 Changed 3 years ago by tomek

  • Description modified (diff)

I would prefer to go with adding inet sockets and binding to loopback address. But it must not be made the default behavior.

Note: See TracTickets for help on using tickets.