Opened 9 years ago

Closed 9 years ago

#381 closed enhancement (fixed)

TSIG key and key ring classes

Reported by: jinmei Owned by: jinmei
Priority: medium Milestone: y2 12 month milestone
Component: libdns++ Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity:
Sub-Project: Feature Depending on Ticket:
Estimated Difficulty: 0.0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

This is the second step of TSIG support.

I'll introduce two quite trivial classes, TSIGKey and TSIGKeyRing, to represent a TSIG key (name, algorithm and secret) and a set of key repository. Independently how we handle the main protocol (sign/verify) we'd need these kinds of concept anyway. So I separated this task as a single step to minimize the code for review in a single cycle.

Subtickets

Change History (6)

comment:1 Changed 9 years ago by jinmei

  • Owner changed from jinmei to UnAssigned
  • Status changed from new to reviewing

branches/trac381 is ready for review. Branch point is r3277.

The implementation should be straightforward. I also noted some possibly non trivial design issues in the documentation.

The original tsig.{c,hh} was renamed to tsigkey.{c,hh}, respectively, and the old content was effectively removed (it wasn't used anywhere). So, for review, it may be easier to simply look at the renamed files rather than to check the diff between the old and new files.

This is the proposed changelog entry.

  112.? [func]		jinmei
	src/lib/dns: introduced two new classes, TSIGKey and TSIGKeyRing,
	to manage TSIG keys. (Trac #381, svn rTBD)

comment:2 Changed 9 years ago by zzchen_pku

  • Owner changed from UnAssigned to zzchen_pku

I will have a look at it.

comment:3 follow-up: Changed 9 years ago by zzchen_pku

  • Owner changed from zzchen_pku to jinmei

Mostly okay, but one branch of TSIGKey::operator=(const TSIGKey& source) isn't tested according to lcov.
For the initial version of TSIGKey, with adding the unittest , I'm okay with the branch.

comment:4 in reply to: ↑ 3 Changed 9 years ago by jinmei

  • Owner changed from jinmei to zzchen_pku

Replying to zzchen_pku:

Mostly okay, but one branch of TSIGKey::operator=(const TSIGKey& source) isn't tested according to lcov.
For the initial version of TSIGKey, with adding the unittest , I'm okay with the branch.

Thanks for the careful check, addressed in r3620.

I've also made one minor fix to the doxygen comment (r3619) which has been in my local copy but was simply forgotten.

comment:5 follow-up: Changed 9 years ago by zzchen_pku

  • Owner changed from zzchen_pku to jinmei

Okay, please go ahead and merge.

comment:6 in reply to: ↑ 5 Changed 9 years ago by jinmei

  • Resolution set to fixed
  • Status changed from reviewing to closed

Replying to zzchen_pku:

Okay, please go ahead and merge.

Thanks, committed, closing.

Note: See TracTickets for help on using tickets.