Opened 9 years ago

Closed 9 years ago

#380 closed enhancement (complete)

Remove duplicate code from _setup_session and config_handler

Reported by: zzchen_pku Owned by: zzchen_pku
Priority: medium Milestone:
Component: secondary manager Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity:
Sub-Project: Feature Depending on Ticket:
Estimated Difficulty: 0.0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

_setup_session and config_handler in zonemgr.py duplicate some code, need to remove them.

Subtickets

Change History (5)

comment:1 Changed 9 years ago by zzchen_pku

  • Status changed from new to accepted

comment:2 Changed 9 years ago by zzchen_pku

  • Owner changed from zzchen_pku to vorner
  • Status changed from accepted to reviewing

Michal, can you help to review this, as you are familiar with it.
Since it is trivial, I don't think we need a separate changelog entry for this change.
Please find the new change in revision r3285, thanks.

comment:3 follow-up: Changed 9 years ago by vorner

  • Owner changed from vorner to zzchen_pku

These changes are ok and I think they can be merged.

However, there's a small question this reminded me of (not direcly related to this change) ‒ from a user point of view, wouldn't it be better if whatever set the value said „0.6 is too much, I'm setting it to 0.5“ instead of just silently setting it? I could imagine a user furiously trying to set his 0.6 and saying „Hey, why it ignores me?“. Do we want do to this kind of thing later on somewhere? Or, is the logic somewhere I didn't notice? Should I bring it to ML or is it already written somewhere?

comment:4 in reply to: ↑ 3 Changed 9 years ago by zzchen_pku

Replying to vorner:

However, there's a small question this reminded me of (not direcly related to this change) ‒ from a user point of view, wouldn't it be better if whatever set the value said „0.6 is too much, I'm setting it to 0.5“ instead of just silently setting it? I could imagine a user furiously trying to set his 0.6 and saying „Hey, why it ignores me?“. Do we want do to this kind of thing later on somewhere? Or, is the logic somewhere I didn't notice? Should I bring it to ML or is it already written somewhere?

Good suggestion, I have updated the log message in r3297.
You can find the jitter logic at http://bind10.isc.org/wiki/SecondaryManager.

comment:5 Changed 9 years ago by zzchen_pku

  • Resolution set to complete
  • Status changed from reviewing to closed

Merged, closing it.

Note: See TracTickets for help on using tickets.