Opened 4 years ago

Closed 4 years ago

#3736 closed defect (fixed)

Cleanup cppcheck warnings

Reported by: marcin Owned by: marcin
Priority: low Milestone: Kea0.9.1
Component: Unclassified Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: Medium
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

There is around 140 warnings reported by cppcheck https://jenkins.isc.org/view/Kea_BuildFarm-developers/job/FreeBSD10.1_32_cpp-check-branch/8/cppcheckResult/

They should be investigated/removed,

Subtickets

Change History (6)

comment:1 Changed 4 years ago by hschempf

  • Milestone changed from Kea-proposed to Kea0.9.1

comment:2 Changed 4 years ago by marcin

  • Owner set to marcin
  • Status changed from new to accepted

comment:3 Changed 4 years ago by marcin

  • Owner changed from marcin to UnAssigned
  • Status changed from accepted to reviewing

This ticket is now ready for the review. It eliminates quite a few issues reported by cppcheck: unusedFunc, useInitializationList, static vs non static functions, unreadVariable, variableScope. None of those were severe errors. When running cppcheck with the --inconclusive switch some errors will still pop-up. They are mainly unusedFunctions (in libraries) and ConfigurationNotChecked for the defines. I think they may be safely ignored for now and the current build farm configuration will not show them.

Running cpp-check in the following way:

cppcheck --enable=warning,style,performance,portability --xml --xml-version=2 --quiet --inline-suppr

should result in no errors. And this is how the build farm runs it.

I don't see the reason for the changelog entry as they are not visible changes.

comment:4 Changed 4 years ago by tmark

  • Owner changed from UnAssigned to tmark

comment:5 Changed 4 years ago by tmark

  • Owner changed from tmark to marcin

The changes look ok.
Please merge.
One question:
Is the removal of dhcp-ubench and folders something that should be
mentioned in ChangeLog?? If so add one.

comment:6 Changed 4 years ago by marcin

  • Resolution set to fixed
  • Status changed from reviewing to closed

Merged with commit ef19bd40aa424c5ccb0353b6633b85a25d55f4a5

Note: See TracTickets for help on using tickets.