Opened 9 years ago

Closed 9 years ago

#373 closed defect (fixed)

lib/config/module_spec.h shouldn't use 'using namespace'

Reported by: jinmei Owned by: jinmei
Priority: low Milestone: y2 12 month milestone
Component: build system Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity:
Sub-Project: Feature Depending on Ticket:
Estimated Difficulty: 0.0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

It currently has the following line:

using namespace isc::data;

We should remove this, and adjust other souce files accordingly.

Subtickets

Change History (3)

comment:1 Changed 9 years ago by jinmei

  • Owner changed from jinmei to jelte
  • Status changed from new to reviewing

I've fixed this in branches/trac373 (there's only one changeset, r3237).

The change should be quite straightforward, but I'm calling for a review in case I miss something.

I believe the best reviewer for this is Jelte, so I'm giving the ticket to him.

comment:2 follow-up: Changed 9 years ago by jelte

  • Owner changed from jelte to jinmei

Looks good

comment:3 in reply to: ↑ 2 Changed 9 years ago by jinmei

  • Resolution set to fixed
  • Status changed from reviewing to closed

Replying to jelte:

Looks good

Thanks for the check. Committed, closing.
(I don't think we need a separate changelog entry for this change).

Note: See TracTickets for help on using tickets.