Opened 9 years ago

Closed 9 years ago

#372 closed enhancement (fixed)

TSIG RDATA support

Reported by: jinmei Owned by: jinmei
Priority: medium Milestone: y2 12 month milestone
Component: libdns++ Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity:
Sub-Project: Feature Depending on Ticket:
Estimated Difficulty: 0.0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description


Subtickets

Change History (8)

comment:1 Changed 9 years ago by jinmei

  • Owner changed from jinmei to UnAssigned
  • Status changed from new to reviewing

branches/trac372 is ready for review. branch point is r3209.

At the moment I've hardcoded mappings between TSIG error codes (e.g. "BADSIG") and their numeric values. I'm planning to introduce a separate class or enum for the codes when adding the main TSIG protocol support, and use the symbolic constants at that point.

comment:2 Changed 9 years ago by jinmei

forgot to add the proposed changelog entry. here it is:

  109.?	[func]		jinmei
	src/lib/dns: Added support for TSIG RDATA.  At this moment this is
	not much of real use, however, because no protocol support was
	added yet.  It will soon be added. (Trac #372, rTBD)

comment:3 follow-up: Changed 9 years ago by zzchen_pku

  • Owner changed from UnAssigned to jinmei

There is a compile error:

rdataclass.cc:2938: error: integer constant is too large for ‘long’ type

I guess it is because I compiled the program in a 32-bit OS.

comment:4 in reply to: ↑ 3 Changed 9 years ago by jinmei

  • Owner changed from jinmei to zzchen_pku

Replying to zzchen_pku:

There is a compile error:

rdataclass.cc:2938: error: integer constant is too large for ‘long’ type

I guess it is because I compiled the program in a 32-bit OS.

Ah, okay. Fixed it in r3632 (in the same way as BIND 9).

comment:5 follow-up: Changed 9 years ago by zzchen_pku

  • Owner changed from zzchen_pku to jinmei

Another two minor questions:

  • rdata_tsig_unittest.cc:234, the same issue as above
  • rdata_tsig_unittest.cc hasn't been added into the Makefile.am

All others ok. Please go ahead and merge after fixing them.

comment:6 in reply to: ↑ 5 ; follow-up: Changed 9 years ago by jinmei

Replying to zzchen_pku:

Another two minor questions:

  • rdata_tsig_unittest.cc:234, the same issue as above
  • rdata_tsig_unittest.cc hasn't been added into the Makefile.am

All others ok. Please go ahead and merge after fixing them.

Thanks for the checks. I've fixed these in r3645 and r3646. (I have no idea how the Makefile.am error could happen...)

I'll merge the latest branch to trunk unless I hear an objection.

comment:7 in reply to: ↑ 6 ; follow-up: Changed 9 years ago by zzchen_pku

Replying to jinmei:

Thanks for the checks. I've fixed these in r3645 and r3646. (I have no idea how the Makefile.am error could happen...)

I guess you forget to commit some changes:-)

I'll merge the latest branch to trunk unless I hear an objection.

Okay.

comment:8 in reply to: ↑ 7 Changed 9 years ago by jinmei

  • Resolution set to fixed
  • Status changed from reviewing to closed

Replying to zzchen_pku:

Okay.

Thanks for the confirmation. Merged, closing.

Note: See TracTickets for help on using tickets.