Opened 9 years ago

Closed 9 years ago

#371 closed enhancement (fixed)

adjust gen-rdatacode for faster build

Reported by: jinmei Owned by: UnAssigned
Priority: low Milestone: y2 12 month milestone
Component: build system Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity:
Sub-Project: Feature Depending on Ticket:
Estimated Difficulty: 0.0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

I'd like to propose some small changes to src/lib/dns/gen-rdatacode.py(.in):

  • in order to decide whether to update rrclass.h, check mtime of dns/rdata instead of that of dns/rdata/in_1, etc. in fact, this is more accurate because what we want to know is when a new supported RR class is added (in_1, ch_3, etc) rather than when some RR type is changed under an RR class. this will also reduce the frequency of updating rrclass.h, and help reduce compile time.
  • in order to decide whether to update rrtype.h, check the mtimes of rrtype_nn.h files only, while the current version also checks the mtimes of rrtype_nn.cc files. Assuming all .cc files have corresponding .h files, this should be sufficient, and this also helps reduce the frequency of updating rrtype.h (and compile time) when we are updating the definition of some RDATA.

The proposed patch is attached to the ticket.

This should be quite trivial, so I'm planning to merge it to trunk soon. But if someone can perform a quick sanity check on it, that would be great. So I'm opening this ticket.

Subtickets

Attachments (1)

gen-rdatacode.diff (1.4 KB) - added by jinmei 9 years ago.

Download all attachments as: .zip

Change History (3)

Changed 9 years ago by jinmei

comment:1 Changed 9 years ago by jinmei

  • Owner changed from jreed to UnAssigned
  • Status changed from new to reviewing

comment:2 in reply to: ↑ description Changed 9 years ago by jinmei

  • Resolution set to fixed
  • Status changed from reviewing to closed

Replying to jinmei:

The proposed patch is attached to the ticket.

This should be quite trivial, so I'm planning to merge it to trunk soon. But if someone can perform a quick sanity check on it, that would be great. So I'm opening this ticket.

I've decided to apply the patch to trunk (r3231). Closing ticket.

Note: See TracTickets for help on using tickets.