Opened 5 years ago

Last modified 4 years ago

#3675 new enhancement

simplify gtest handling in configure

Reported by: fdupont Owned by:
Priority: low Milestone: Outstanding Tasks
Component: build system Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

Cf. #3162 last Stephen's comments (reproduced below):

As an aside, the logic processing the gtest switches options in configure.ac seems excessively complicated and incomplete. If nothing else, it allows both --with-gtest and --with-gtest-source to be specified and does not complain.

=> --with-gtest-source enforces --with-gtest so is a sub case?

Also, when processing the --with-gtest-source option, configure.ac checks for both gtest-all.cc and gtest_main.cc, but we only make use of gtest-all.cc. gtest-all.cc was introduced in gtest 1.2.0 (released in November 2008); I think this is far enough back for us not to worry about supporting building gtest using gtest_main.cc.
I suggest that we raise a ticket to tidy up the gtest handling in configure.ac.

Subtickets

Change History (3)

comment:1 Changed 5 years ago by tomek

  • Milestone changed from Kea-proposed to DHCP Outstanding Tasks

comment:2 Changed 4 years ago by tmark

  • Component changed from configuration to build system

comment:3 Changed 4 years ago by tomek

  • Milestone changed from DHCP Outstanding Tasks to Outstanding Tasks

Milestone renamed

Note: See TracTickets for help on using tickets.