Opened 9 years ago

Closed 9 years ago

#362 closed defect (fixed)

python coverage report via make

Reported by: jreed Owned by: jreed
Priority: medium Milestone:
Component: Unclassified Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity:
Sub-Project: Feature Depending on Ticket:
Estimated Difficulty: 0.0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

I have minor configure.ac and Makefile.am changes to add python coverage report via make.

Subtickets

Change History (6)

comment:1 Changed 9 years ago by jreed

  • Owner changed from jreed to UnAssigned
  • Status changed from new to reviewing

See branches/trac362. See the README for details.

comment:2 Changed 9 years ago by jelte

  • Owner changed from UnAssigned to jelte

comment:3 follow-up: Changed 9 years ago by jelte

  • Owner changed from jelte to jreed

Awesome, love it.

Few comments:

the merge with sync ended up in a file that is now missing in this
branch (src/bin/xfrin/xfrin.spec)

there does not appear to be a way to only run the python coverage tests;
added to that, after
./configure --with-pycoverage
make coverage fails since lcov wasn't specified, and vice versa.

Not sure if we want to have separate targets, but if not, we should
either have something like ./configure --enable-coverage that configures both, or
only let make coverage run the specific subset specified at
configure-time.

very small nit for the tester without patience, perhaps mention the
output directories also in the first make target (coverage), since the
rest are for most use-cases not that interesting (or possibly say this
even before mentioning targets).

The output directories for c++ and python coverage could be a little
more consistent (no real preference, but 'coverage' seems to
generic, esp. compared to py-coverage-html, i'd prefer something like
'coverage-cpp' and 'coverage-py' but again, no real preference)

comment:4 in reply to: ↑ 3 ; follow-up: Changed 9 years ago by jreed

Replying to jelte:

there does not appear to be a way to only run the python coverage tests;
added to that, after
./configure --with-pycoverage
make coverage fails since lcov wasn't specified, and vice versa.

Not sure if we want to have separate targets, but if not, we should
either have something like ./configure --enable-coverage that configures both, or
only let make coverage run the specific subset specified at
configure-time.

Okay I remove the "exit 1" from each of these. It is okay not to error out I think and just show the message.

very small nit for the tester without patience, perhaps mention the
output directories also in the first make target (coverage), since the
rest are for most use-cases not that interesting (or possibly say this
even before mentioning targets).

I am not sure I understand. You want it to echo the location?
I now have it output like:

Generated Python Code Coverage report in HTML at /backup/isc-work-svn/svn/branches/trac362/coverage-python-html

The output directories for c++ and python coverage could be a little
more consistent (no real preference, but 'coverage' seems to
generic, esp. compared to py-coverage-html, i'd prefer something like
'coverage-cpp' and 'coverage-py' but again, no real preference)

I renamed the directories to coverage-cpp-html and coverage-python-html.

comment:5 in reply to: ↑ 4 Changed 9 years ago by jelte

Replying to jreed:

Replying to jelte:

Not sure if we want to have separate targets, but if not, we should
either have something like ./configure --enable-coverage that configures both, or
only let make coverage run the specific subset specified at
configure-time.

Okay I remove the "exit 1" from each of these. It is okay not to error out I think and just show the message.

cool

very small nit for the tester without patience, perhaps mention the
output directories also in the first make target (coverage), since the
rest are for most use-cases not that interesting (or possibly say this
even before mentioning targets).

I am not sure I understand. You want it to echo the location?
I now have it output like:

Generated Python Code Coverage report in HTML at /backup/isc-work-svn/svn/branches/trac362/coverage-python-html

oh, no i was just talking about the README file itself; what i had in mind was mentioning the output directories in the 'introduction' (i.e. the text before summing up the actual make targets). But it was only an extremely minor nit and the text is fine as it is. Oh except the name of the output directory for cpp coverage is now out of date :)

The output directories for c++ and python coverage could be a little
more consistent (no real preference, but 'coverage' seems to
generic, esp. compared to py-coverage-html, i'd prefer something like
'coverage-cpp' and 'coverage-py' but again, no real preference)

I renamed the directories to coverage-cpp-html and coverage-python-html.

awesome.

thumbs up :)

comment:6 Changed 9 years ago by jreed

  • Resolution set to fixed
  • Status changed from reviewing to closed

Committed to trunk at r4023

Note: See TracTickets for help on using tickets.