Opened 9 years ago

Closed 9 years ago

#355 closed defect (fixed)

src/bin/tests causes distcheck failure

Reported by: jinmei Owned by: jinmei
Priority: low Milestone: y2 12 month milestone
Component: build system Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity:
Sub-Project: Feature Depending on Ticket:
Estimated Difficulty: 0.0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

The attached patch should fix the problem.

Maybe sufficiently trivial, but I'm giving the ticket to Michal for a sanity check.

Subtickets

Attachments (2)

bin-tests.diff (1.3 KB) - added by jinmei 9 years ago.
scan-makefile.diff (1.2 KB) - added by vorner 9 years ago.

Download all attachments as: .zip

Change History (6)

Changed 9 years ago by jinmei

comment:1 Changed 9 years ago by jinmei

  • Status changed from new to reviewing

(forgot to note this: I think this is very minor so it won't require a changelog entry)

Changed 9 years ago by vorner

comment:2 follow-up: Changed 9 years ago by vorner

  • Owner changed from vorner to jinmei

I see the problem and the solution seems sane. However, Makefile.in files live in the srcdir, not builddir, so I suggest to scan Makefile files instead (they live in the build dir). Could you have a look at the other patch (both would be applied in the end) in turn?

Thank you

comment:3 in reply to: ↑ 2 ; follow-up: Changed 9 years ago by jinmei

Replying to vorner:

I see the problem and the solution seems sane. However, Makefile.in files live in the srcdir, not builddir, so I suggest to scan Makefile files instead (they live in the build dir). Could you have a look at the other patch (both would be applied in the end) in turn?

Ah, good point. I'll merge your incremental patch and apply it to trunk.

Thanks for the review.

comment:4 in reply to: ↑ 3 Changed 9 years ago by jinmei

  • Resolution set to fixed
  • Status changed from reviewing to closed

Replying to jinmei:

Replying to vorner:

I see the problem and the solution seems sane. However, Makefile.in files live in the srcdir, not builddir, so I suggest to scan Makefile files instead (they live in the build dir). Could you have a look at the other patch (both would be applied in the end) in turn?

Ah, good point. I'll merge your incremental patch and apply it to trunk.

Thanks for the review.

Commit done. Closing ticket.

Note: See TracTickets for help on using tickets.