Opened 9 years ago

Closed 9 years ago

#354 closed enhancement (fixed)

minor cleanup: generate wire testdata automatically

Reported by: jinmei Owned by: jinmei
Priority: low Milestone: y2 12 month milestone
Component: libdns++ Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity:
Sub-Project: Feature Depending on Ticket:
Estimated Difficulty: 0.0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

Some of test data for wire format images are generated by src/lib/dns/tests/testdata/gen-wiredata.py. Currently we have both the source files (.sepc) and generated files in the repository, but it would be better to have only the former. trac #311 partially did it. I'm going to make the same changes for other data files.

Subtickets

Change History (5)

comment:1 in reply to: ↑ description Changed 9 years ago by jinmei

  • Owner changed from jinmei to UnAssigned
  • Status changed from new to reviewing

Trac #354 is ready for review.

Actually this is quite trivial, so if others are busy to take on this one and I cannot get a reviewer soon, I'll merge it to trunk anyway.

Note also that this branch contains a differetn distcheck fix: we needed to add this:

EXTRA_DIST += testutil.py

to lib/dns/python/tests/Makefile.am. At least this must be merged quickly.

comment:2 Changed 9 years ago by vorner

  • Owner changed from UnAssigned to vorner

comment:3 follow-up: Changed 9 years ago by vorner

  • Owner changed from vorner to jinmei

I do not see a problem, I think it can be merged.

Just out of curiosity, where this syntax come from?:

.spec.wire:
        some_rule

I know things like:

%.wire: %.spec

Is it a shortcut, or they're different somehow?

comment:4 in reply to: ↑ 3 Changed 9 years ago by jinmei

Replying to vorner:

I do not see a problem, I think it can be merged.

Thanks for the review.

Just out of curiosity, where this syntax come from?:

.spec.wire:
        some_rule

It's an automake rule. See http://www.gnu.org/software/hello/manual/automake/Suffixes.html#Suffixes

comment:5 Changed 9 years ago by jinmei

  • Resolution set to fixed
  • Status changed from reviewing to closed

merge done. closing ticket.

Note: See TracTickets for help on using tickets.