Opened 9 years ago

Closed 9 years ago

#351 closed enhancement (fixed)

cleanup for DNS opcode and rcode

Reported by: jinmei Owned by: jinmei
Priority: medium Milestone: y2 12 month milestone
Component: libdns++ Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity:
Sub-Project: Feature Depending on Ticket:
Estimated Difficulty: 0.0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

This is a next round of cleanups for the DNS message related classes.

This one should be quite trivial: mostly for completing documentation and adding more tests.

Subtickets

Change History (4)

comment:1 Changed 9 years ago by jinmei

  • Owner changed from jinmei to UnAssigned
  • Status changed from new to reviewing

branches/trac351 is ready for review. branch point is r3014.

The diff is large, but it's mostly trivial: moving Opcode and Rcode related code to separate files with more documentation and some more additional tests.

I've also changed the way to maintain Opcode and Rcode in the Message class. Instead of keeping a reference, the new code holds a local copy since copying these objects should be cheap and it reduces the risk of having a dangling reference (I actually encountered this type of bug in the python binding).

Proposed changelog entry is as follows:

  100.	[func]		jinmei
	src/lib/dns: Completed Opcode and Rcode implementation with more
	tests and documentation.  API is mostly the same but the
	validation was a bit tightened. (Trac #351, svn rTBD)

comment:2 Changed 9 years ago by vorner

  • Owner changed from UnAssigned to vorner

comment:3 follow-up: Changed 9 years ago by vorner

  • Owner changed from vorner to jinmei

I don't see any problem, I think it can be merged.

comment:4 in reply to: ↑ 3 Changed 9 years ago by jinmei

  • Resolution set to fixed
  • Status changed from reviewing to closed

Replying to vorner:

I don't see any problem, I think it can be merged.

Thanks for review, merged to trunk, closing ticket.

Note: See TracTickets for help on using tickets.