Opened 5 years ago

Last modified 3 years ago

#3489 assigned defect

Sunstudio and needed include string.h in lib/util

Reported by: jreed Owned by: jreed
Priority: very low Milestone: Solaris and other unsupported
Component: libutil Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: Core Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description (last modified by tomek)

See build output at
http://git.kea.isc.org/~tester/builder/KEA/20140711190501-Solaris10-sparc-Sunstudio/logs/build.out

This is on Solaris 10 with sunstudio:

libtool: compile:  /usr/bin/CC -DHAVE_CONFIG_H -I. -I../../.. -I../../../src/lib -I../../../src/lib -I../../../src/lib/util -I../../../src/lib/util -I../../../src/lib/exceptions -I../../../src/lib/exceptions -I/udir/jreed/pkg/include -D_XPG4_2 -D__EXTENSIONS__ -DOS_SUN -DBOOST_DISABLE_THREADS=1 -I../../../ext/asio -I../../../ext/coroutine -DASIO_DISABLE_THREADS=1 -g -library=stlport4 -features=tmplife -features=tmplrefstatic -c signal_set.cc  -KPIC -DPIC -o .libs/signal_set.o
"signal_set.cc", line 100: Error: The function "memset" must have a prototype.
"signal_set.cc", line 104: Error: The function "strerror" must have a prototype.

It needs +#include <string.h>

Subtickets

Change History (9)

comment:1 Changed 5 years ago by tomek

  • Milestone changed from Kea-proposed to Kea0.9

Although we don't support Solaris, adding a single include is not big of a deal, so we can do it in 0.9. Especially that it may help on other systems, as Jeremy pointed out.

comment:2 Changed 5 years ago by jreed

  • Owner set to jreed
  • Status changed from new to assigned

comment:3 Changed 5 years ago by tomek

  • Milestone changed from Kea0.9 to Kea0.9.1
  • Priority changed from low to very low
  • Version set to git

This didn't make it into 0.9, moving to 0.9.1.

Also, lowering priority to very low. We are not supporting Solaris 11 yet, much less Solaris 10, which doesn't support getifaddrs. It is likely that we will never support it.

comment:4 Changed 5 years ago by tomek

  • Milestone changed from Kea0.9.1 to DHCP Outstanding Tasks

Moving to outstanding DHCP tickets as discussed on Kea call (2014-10-08).

I'm sorry, but this soft of tickets are tricky to deal with. Even though the change may be simple, one of the engineers must get a Solaris box (either work remotely or set up a VM on his own), configure the environment (which takes a lot of time for someone unfamiliar with Solaris), then build Kea code and run unit-tests.

I'm afraid that is just too much effort for a platform that we do not support. We will get to Solaris one day, it just too early at this stage.

comment:5 Changed 5 years ago by fdupont

Same comment than for 'ps vs Solaris' and in this case the include is really needed by the standard. To summary: world != Linux.

comment:6 Changed 5 years ago by fdupont

Fixed (and BTW it is std::memset() and std::strerror()).

comment:7 Changed 4 years ago by tomek

  • Milestone changed from DHCP Outstanding Tasks to Outstanding Tasks

Milestone renamed

comment:8 Changed 3 years ago by tomek

  • Description modified (diff)
  • Milestone changed from Outstanding Tasks to Solaris-and-exotic-systems

comment:9 Changed 3 years ago by tomek

  • Milestone changed from Solaris-and-exotic-systems to Solaris and other unsupported

Milestone renamed

Note: See TracTickets for help on using tickets.